Update docstring for UserDetailsView and cleanup

Author: maxim-kht

rest_auth/registration/serializers.py

@@ -63,11 +63,11 @@ def validate(self, attrs):
         # http://stackoverflow.com/questions/8666316/facebook-oauth-2-0-code-and-token
 
         # Case 1: We received the access_token
-        if('access_token' in attrs):
+        if 'access_token' in attrs:
             access_token = attrs.get('access_token')
 
         # Case 2: We received the authorization code
-        elif('code' in attrs):
+        elif 'code' in attrs:
             self.callback_url = getattr(view, 'callback_url', None)
             self.client_class = getattr(view, 'client_class', None)
 

rest_auth/views.py

@@ -9,9 +9,8 @@
 from rest_framework import status
 from rest_framework.views import APIView
 from rest_framework.response import Response
-from rest_framework.generics import GenericAPIView
+from rest_framework.generics import GenericAPIView, RetrieveUpdateAPIView
 from rest_framework.permissions import IsAuthenticated, AllowAny
-from rest_framework.generics import RetrieveUpdateAPIView
 
 if 'allauth' in settings.INSTALLED_APPS:
     from allauth.account import app_settings as allauth_settings
@@ -22,7 +21,6 @@
     PasswordChangeSerializer, JWTSerializer, create_token
 )
 from .models import TokenModel
-
 from .utils import jwt_encode
 
 
@@ -123,13 +121,14 @@ def logout(self, request):
 
 class UserDetailsView(RetrieveUpdateAPIView):
     """
-    Returns User's details in JSON format.
+    Reads and updates UserModel fields
+    Accepts GET, PUT, PATCH methods.
+
+    Default accepted fields: username, first_name, last_name
+    Default display fields: pk, username, email, first_name, last_name
+    Read-only fields: pk, email
 
-    Accepts the following GET parameters: token
-    Accepts the following POST parameters:
-        Required: token
-        Optional: email, first_name, last_name and UserProfile fields
-    Returns the updated UserProfile and/or User object.
+    Returns UserModel fields.
     """
     serializer_class = UserDetailsSerializer
     permission_classes = (IsAuthenticated,)