Brought back pass verification + added test

Author: mariodev

docs/api_endpoints.rst

@@ -51,7 +51,8 @@ Registration
 - /rest-auth/registration/ (POST)
 
     - username
-    - password
+    - password1
+    - password2
     - email
 
 - /rest-auth/registration/verify-email/ (POST)

rest_auth/registration/serializers.py

@@ -122,11 +122,13 @@ def validate(self, attrs):
 
 class RegisterSerializer(serializers.Serializer):
     username = serializers.CharField(
-                               max_length=get_username_max_length(),
-                               min_length=allauth_settings.USERNAME_MIN_LENGTH,
-                               required=allauth_settings.USERNAME_REQUIRED)
+        max_length=get_username_max_length(),
+        min_length=allauth_settings.USERNAME_MIN_LENGTH,
+        required=allauth_settings.USERNAME_REQUIRED
+    )
     email = serializers.EmailField(required=allauth_settings.EMAIL_REQUIRED)
-    password = serializers.CharField(required=True, write_only=True)
+    password1 = serializers.CharField(required=True, write_only=True)
+    password2 = serializers.CharField(required=True, write_only=True)
 
     def validate_username(self, username):
         username = get_adapter().clean_username(username)
@@ -140,16 +142,21 @@ def validate_email(self, email):
                     "A user is already registered with this e-mail address.")
         return email
 
-    def validate_password(self, password):
+    def validate_password1(self, password):
         return get_adapter().clean_password(password)
 
+    def validate(self, data):
+        if data['password1'] != data['password2']:
+            raise serializers.ValidationError("The two password fields didn't match.")
+        return data
+
     def custom_signup(self, request, user):
         pass
 
     def get_cleaned_data(self):
         return {
             'username': self.validated_data.get('username', ''),
-            'password1': self.validated_data.get('password', ''),
+            'password1': self.validated_data.get('password1', ''),
             'email': self.validated_data.get('email', '')
         }
 

rest_auth/tests/test_api.py

@@ -28,7 +28,8 @@ class APITestCase1(TestCase, BaseAPITestCase):
     # data without user profile
     REGISTRATION_DATA = {
         "username": USERNAME,
-        "password": PASS,
+        "password1": PASS,
+        "password2": PASS
     }
 
     REGISTRATION_DATA_WITH_EMAIL = REGISTRATION_DATA.copy()
@@ -271,6 +272,12 @@ def test_registration(self):
         self._login()
         self._logout()
 
+    def test_registration_with_invalid_password(self):
+        data = self.REGISTRATION_DATA.copy()
+        data['password2'] = 'foobar'
+
+        self.post(self.register_url, data=data, status_code=400)
+
     @override_settings(
         ACCOUNT_EMAIL_VERIFICATION='mandatory',
         ACCOUNT_EMAIL_REQUIRED=True

rest_auth/tests/test_social.py

@@ -21,7 +21,8 @@ class TestSocialAuth(TestCase, BaseAPITestCase):
     EMAIL = "[email protected]"
     REGISTRATION_DATA = {
         "username": USERNAME,
-        "password": PASS,
+        "password1": PASS,
+        "password2": PASS,
         "email": EMAIL
     }