js: add correct href to "Show all results..."

There was some js sourcery happening to make a click on the
"Show all results..." entry in the search results dropdown go to the
search page.

Instead of doing the sourcery on click, set a proper `href` attribute on
the `<a>`. This also makes browsers show a hand cursor when hovering the
entry in the dropdown.

Signed-off-by: Toon Claes <[email protected]>

Author: To1ne

assets/js/application.js

@@ -223,7 +223,12 @@ var Search = {
             $("#show-results-label").text("No matching pages found.");
             return;
           }
-          $("#show-results-label").text("Show all results...");
+
+          const language = document.querySelector("html")?.getAttribute("lang");
+          $("#show-results-label")
+            .text("Show all results...")
+            .attr('href', `${baseURLPrefix}search/results?search=${term}${language && `&language=${language}`}`);
+
           const loadButton = $("#load-more-results");
           loadButton.text(`Loading ${
             results.results.length < 2
@@ -300,11 +305,6 @@ var Search = {
   selectResultOption: function() {
     var link = $('#search-results a')[Search.selectedIndex];
     var url = $(link).attr('href');
-    if(!url) {
-      const term = $('#search-text').val();
-      const language = document.querySelector("html")?.getAttribute("lang");
-      url = `${baseURLPrefix}search/results?search=${term}${language && `&language=${language}`}`;
-    }
     window.location.href = url;
     selectedIndex = 0;
   },

tests/git-scm.spec.js

@@ -115,7 +115,8 @@ test('search', async ({ page }) => {
   // Expect the first search result to be "git-commit"
   const searchResults = page.locator('#search-results')
   await expect(searchResults.getByRole("link")).not.toHaveCount(0)
-  await expect(searchResults.getByRole("link").nth(0)).toHaveText('git-commit')
+  await expect(searchResults.getByRole("link").nth(0)).toHaveText('Show all results...')
+  await expect(searchResults.getByRole("link").nth(1)).toHaveText('git-commit')
 
   // Expect the search page to show up
   await searchBox.press('Enter')
@@ -137,7 +138,8 @@ test('search', async ({ page }) => {
   await page.goto(`${url}docs/git-commit/fr`)
   await searchBox.fill('add')
   await searchBox.press('Shift')
-  await expect(searchResults.getByRole("link").nth(0)).toHaveAttribute('href', /\/docs\/git-add\/fr(\.html)?$/)
+  await expect(searchResults.getByRole("link").nth(0)).toHaveAttribute('href', /\/search\/results\?search=add&language=fr$/)
+  await expect(searchResults.getByRole("link").nth(1)).toHaveAttribute('href', /\/docs\/git-add\/fr(\.html)?$/)
 
   // pressing the Enter key should navigate to the full search results page
   await searchBox.press('Enter')