Ability to search with Ctrl-F?

[ankon]

The color parsing works great, thanks a lot for that -- it helps when looking at color output of commands.

I would be great if one could search for strings in the preview though. Not sure how trivial or painful that would be to implement :/

[TobiasFaller]

I tried to use the internal search feature of the VS Code Webview.
However, it tends to crash the full application when closing and re-opening the preview (0xc0000005 Access Violation).
I'll have to write a bug report. Additionally, in VS Codium it doesn't search at all.

I'll see what I can do for now.
Maybe I'll implement a custom search function for the time being.

[TobiasFaller]

I've filed a bug report for VS Code:

• Re-opening WebViewPanel with search box crashes VS Code microsoft/vscode#212544

[TobiasFaller]

Update: Microsoft uses a custom build of electron, while in the default version no findInFrame function is implemented.
Therefore, I can't troubleshoot the issue in this case as the implementation is not available.

Edit: The new find functionality seems to be in the process of currently being upstreamed.

• Be able to download Microsoft built electron (Microsoft/vscode-electron-prebuilt) microsoft/vscode#201176
• Iframe webview: search can crash the process microsoft/vscode#126729
• feat: add webFrameMain.findInFrame/stopFindInFrame electron/electron#28274