fix!: support target_columns_to_types

eakmanrq · eakmanrq · commit f24b8b8dc351 · 2025-08-25T10:23:08.000-07:00
diff --git a/sqlmesh_utils/materializations/non_idempotent_incremental_by_time_range.py b/sqlmesh_utils/materializations/non_idempotent_incremental_by_time_range.py
@@ -116,7 +116,7 @@ def _inject_alias(node: exp.Expression, alias: str) -> exp.Expression:
         self.adapter.merge(
             target_table=table_name,
             source_table=query_or_df,
-            columns_to_types=columns_to_types,
+            target_columns_to_types=columns_to_types,
             unique_key=model.kind.primary_key,
             merge_filter=exp.and_(*betweens),
         )
diff --git a/tests/materializations/integration/test_integration_non_idempotent_incremental_by_time_range.py b/tests/materializations/integration/test_integration_non_idempotent_incremental_by_time_range.py
@@ -30,7 +30,7 @@ def test_basic_usage(project: Project):
     }
 
     project.engine_adapter.create_table(
-        upstream_table_name, columns_to_types=upstream_table_columns
+        upstream_table_name, target_columns_to_types=upstream_table_columns
     )
     project.engine_adapter.insert_append(
         upstream_table_name,
@@ -122,7 +122,7 @@ def test_partial_restatement(project: Project):
     }
 
     project.engine_adapter.create_table(
-        upstream_table_name, columns_to_types=upstream_table_columns
+        upstream_table_name, target_columns_to_types=upstream_table_columns
     )
     project.engine_adapter.insert_append(
         upstream_table_name,
@@ -174,7 +174,7 @@ def test_partial_restatement(project: Project):
     # change upstream data
     project.engine_adapter.drop_table(upstream_table_name)
     project.engine_adapter.create_table(
-        upstream_table_name, columns_to_types=upstream_table_columns
+        upstream_table_name, target_columns_to_types=upstream_table_columns
     )
     project.engine_adapter.insert_append(
         upstream_table_name,

Original file line number	Diff line number	Diff line change
`@@ -116,7 +116,7 @@ def _inject_alias(node: exp.Expression, alias: str) -> exp.Expression:`
`116`	`116`	`self.adapter.merge(`
`117`	`117`	`target_table=table_name,`
`118`	`118`	`source_table=query_or_df,`
`119`		`- columns_to_types=columns_to_types,`
	`119`	`+ target_columns_to_types=columns_to_types,`
`120`	`120`	`unique_key=model.kind.primary_key,`
`121`	`121`	`merge_filter=exp.and_(*betweens),`
`122`	`122`	`)`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ def test_basic_usage(project: Project):`
`30`	`30`	`}`
`31`	`31`
`32`	`32`	`project.engine_adapter.create_table(`
`33`		`- upstream_table_name, columns_to_types=upstream_table_columns`
	`33`	`+ upstream_table_name, target_columns_to_types=upstream_table_columns`
`34`	`34`	`)`
`35`	`35`	`project.engine_adapter.insert_append(`
`36`	`36`	`upstream_table_name,`
`@@ -122,7 +122,7 @@ def test_partial_restatement(project: Project):`
`122`	`122`	`}`
`123`	`123`
`124`	`124`	`project.engine_adapter.create_table(`
`125`		`- upstream_table_name, columns_to_types=upstream_table_columns`
	`125`	`+ upstream_table_name, target_columns_to_types=upstream_table_columns`
`126`	`126`	`)`
`127`	`127`	`project.engine_adapter.insert_append(`
`128`	`128`	`upstream_table_name,`
`@@ -174,7 +174,7 @@ def test_partial_restatement(project: Project):`
`174`	`174`	`# change upstream data`
`175`	`175`	`project.engine_adapter.drop_table(upstream_table_name)`
`176`	`176`	`project.engine_adapter.create_table(`
`177`		`- upstream_table_name, columns_to_types=upstream_table_columns`
	`177`	`+ upstream_table_name, target_columns_to_types=upstream_table_columns`
`178`	`178`	`)`
`179`	`179`	`project.engine_adapter.insert_append(`
`180`	`180`	`upstream_table_name,`