Chore!: bump sqlglot to v28.7.0 (#5686)

Author: georgesittas

pyproject.toml

@@ -24,7 +24,7 @@ dependencies = [
     "requests",
     "rich[jupyter]",
     "ruamel.yaml",
-    "sqlglot[rs]~=28.6.0",
+    "sqlglot[rs]~=28.7.0",
     "tenacity",
     "time-machine",
     "json-stream"

sqlmesh/core/state_sync/common.py

@@ -140,7 +140,7 @@ def all_batch_range(cls) -> ExpiredBatchRange:
     def _expanded_tuple_comparison(
         cls,
         columns: t.List[exp.Column],
-        values: t.List[exp.Literal],
+        values: t.List[t.Union[exp.Literal, exp.Neg]],
         operator: t.Type[exp.Expression],
     ) -> exp.Expression:
         """Generate expanded tuple comparison that works across all SQL engines.

tests/core/test_snapshot_evaluator.py

@@ -2131,7 +2131,7 @@ def test_temp_table_includes_schema_for_ignore_changes(
     model = SqlModel(
         name="test_schema.test_model",
         kind=IncrementalByTimeRangeKind(
-            time_column="a", on_destructive_change=OnDestructiveChange.IGNORE
+            time_column="ds", on_destructive_change=OnDestructiveChange.IGNORE
         ),
         query=parse_one("SELECT c, a FROM tbl WHERE ds BETWEEN @start_ds and @end_ds"),
     )
@@ -2148,6 +2148,7 @@ def columns(table_name):
         return {
             "c": exp.DataType.build("int"),
             "a": exp.DataType.build("int"),
+            "ds": exp.DataType.build("timestamp"),
         }
 
     adapter.columns = columns  # type: ignore
@@ -4321,13 +4322,14 @@ def test_multiple_engine_promotion(mocker: MockerFixture, adapter_mock, make_sna
     def columns(table_name):
         return {
             "a": exp.DataType.build("int"),
+            "ds": exp.DataType.build("timestamp"),
         }
 
     adapter.columns = columns  # type: ignore
 
     model = SqlModel(
         name="test_schema.test_model",
-        kind=IncrementalByTimeRangeKind(time_column="a"),
+        kind=IncrementalByTimeRangeKind(time_column="ds"),
         gateway="secondary",
         query=parse_one("SELECT a FROM tbl WHERE ds BETWEEN @start_ds and @end_ds"),
     )
@@ -4350,10 +4352,10 @@ def columns(table_name):
     cursor_mock.execute.assert_has_calls(
         [
             call(
-                f'DELETE FROM "sqlmesh__test_schema"."test_schema__test_model__{snapshot.version}" WHERE "a" BETWEEN 2020-01-01 00:00:00+00:00 AND 2020-01-02 23:59:59.999999+00:00'
+                f'DELETE FROM "sqlmesh__test_schema"."test_schema__test_model__{snapshot.version}" WHERE "ds" BETWEEN CAST(\'2020-01-01 00:00:00\' AS TIMESTAMP) AND CAST(\'2020-01-02 23:59:59.999999\' AS TIMESTAMP)'
             ),
             call(
-                f'INSERT INTO "sqlmesh__test_schema"."test_schema__test_model__{snapshot.version}" ("a") SELECT "a" FROM (SELECT "a" AS "a" FROM "tbl" AS "tbl" WHERE "ds" BETWEEN \'2020-01-01\' AND \'2020-01-02\') AS "_subquery" WHERE "a" BETWEEN 2020-01-01 00:00:00+00:00 AND 2020-01-02 23:59:59.999999+00:00'
+                f'INSERT INTO "sqlmesh__test_schema"."test_schema__test_model__{snapshot.version}" ("a", "ds") SELECT "a", "ds" FROM (SELECT "a" AS "a" FROM "tbl" AS "tbl" WHERE "ds" BETWEEN \'2020-01-01\' AND \'2020-01-02\') AS "_subquery" WHERE "ds" BETWEEN CAST(\'2020-01-01 00:00:00\' AS TIMESTAMP) AND CAST(\'2020-01-02 23:59:59.999999\' AS TIMESTAMP)'
             ),
         ]
     )