Skip to content

Commit cb3a938

Browse files
committed
update test to skip for unicode characters due to Doris compatibility issues.
1 parent 9cf11b5 commit cb3a938

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

sqlmesh/core/engine_adapter/doris.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,6 @@ class DorisEngineAdapter(
5454
SUPPORTS_MATERIALIZED_VIEW_SCHEMA = True
5555
SUPPORTS_CREATE_DROP_CATALOG = False
5656
INSERT_OVERWRITE_STRATEGY = InsertOverwriteStrategy.DELETE_INSERT
57-
# default setting `enable_unicode_name_support=false` so it is incompatible with unicode characters in model names
58-
QUOTE_IDENTIFIERS_IN_VIEWS = False
5957

6058
def create_schema(
6159
self,

tests/core/engine_adapter/integration/test_integration.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4086,6 +4086,11 @@ def test_unicode_characters(ctx: TestContext, tmp_path: Path):
40864086
# I also think Spark may not support unicode in general but that would need to be verified.
40874087
if not ctx.engine_adapter.QUOTE_IDENTIFIERS_IN_VIEWS:
40884088
pytest.skip("Skipping as these engines have issues with unicode characters in model names")
4089+
# Doris default setting `enable_unicode_name_support=false` so it is incompatible with unicode characters in model names
4090+
if ctx.dialect == "doris":
4091+
pytest.skip(
4092+
"Skipping as Doris default setting has issues with unicode characters in model names"
4093+
)
40894094

40904095
model_name = "客户数据"
40914096
table = ctx.table(model_name).sql(dialect=ctx.dialect)

0 commit comments

Comments
 (0)