Skip to content

Commit e4cb63e

Browse files
authored
fix: normalize audit canonical name (#5448)
1 parent 89e74bc commit e4cb63e

File tree

2 files changed

+26
-1
lines changed

2 files changed

+26
-1
lines changed

sqlmesh/dbt/test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ def _lowercase_name(cls, v: str) -> str:
111111

112112
@property
113113
def canonical_name(self) -> str:
114-
return f"{self.package_name}.{self.name}" if self.package_name else self.name
114+
return f"{self.package_name}.{self.name}".lower() if self.package_name else self.name
115115

116116
@property
117117
def is_standalone(self) -> bool:

tests/dbt/test_config.py

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -245,6 +245,31 @@ def test_test_to_sqlmesh_fields():
245245
assert audit.dialect == "bigquery"
246246

247247

248+
def test_test_config_canonical_name():
249+
test_config_upper_case_package = TestConfig(
250+
name="foo_test",
251+
package_name="TEST_PACKAGE",
252+
sql="SELECT 1",
253+
)
254+
255+
assert test_config_upper_case_package.canonical_name == "test_package.foo_test"
256+
257+
test_config_mixed_case_package = TestConfig(
258+
name="Bar_Test",
259+
package_name="MixedCase_Package",
260+
sql="SELECT 1",
261+
)
262+
263+
assert test_config_mixed_case_package.canonical_name == "mixedcase_package.bar_test"
264+
265+
test_config_no_package = TestConfig(
266+
name="foo_bar_test",
267+
sql="SELECT 1",
268+
)
269+
270+
assert test_config_no_package.canonical_name == "foo_bar_test"
271+
272+
248273
def test_singular_test_to_standalone_audit(dbt_dummy_postgres_config: PostgresConfig):
249274
sql = "SELECT * FROM FOO.BAR WHERE cost > 100"
250275
test_config = TestConfig(

0 commit comments

Comments
 (0)