refactor: move fakeDeployer and bytesFromString to testhelpers_test.go for better organization

Author: ToeiRei

internal/deploy/audit_test.go

@@ -5,7 +5,6 @@
 package deploy_test
 
 import (
-	"bytes"
 	"testing"
 
 	"github.com/toeirei/keymaster/internal/core"
@@ -14,16 +13,6 @@ import (
 	"github.com/toeirei/keymaster/internal/model"
 )
 
-// fakeDeployer implements core.RemoteDeployer for tests.
-type fakeDeployer struct {
-	content []byte
-	seen    string
-}
-
-func (f *fakeDeployer) DeployAuthorizedKeys(content string) error { f.seen = content; return nil }
-func (f *fakeDeployer) GetAuthorizedKeys() ([]byte, error)        { return f.content, nil }
-func (f *fakeDeployer) Close()                                    {}
-
 func TestAuditAccountSerial_Errors(t *testing.T) {
 	if err := db.InitDB("sqlite", ":memory:"); err != nil {
 		t.Fatalf("db.InitDB failed: %v", err)
@@ -91,7 +80,4 @@ func TestAuditAccountStrict_DriftDetected(t *testing.T) {
 	}
 }
 
-// small helpers to avoid importing bytes package directly in test bodies
-// small helpers to avoid importing bytes package directly in test bodies
-// small helpers to avoid importing bytes package directly in test bodies
-func bytesFromString(s string) *bytes.Buffer { return bytes.NewBufferString(s) }
+// bytesFromString is provided by testhelpers_test.go

internal/deploy/testhelpers_test.go

@@ -0,0 +1,22 @@
+// Copyright (c) 2025 ToeiRei
+// Keymaster - SSH key management system
+// This source code is licensed under the MIT license found in the LICENSE file.
+
+package deploy_test
+
+import "bytes"
+
+// fakeDeployer implements core.RemoteDeployer for tests and is shared
+// so multiple test files can override `core.NewDeployerFactory` without
+// redeclaring the type.
+type fakeDeployer struct {
+	content []byte
+	seen    string
+}
+
+func (f *fakeDeployer) DeployAuthorizedKeys(content string) error { f.seen = content; return nil }
+func (f *fakeDeployer) GetAuthorizedKeys() ([]byte, error)        { return f.content, nil }
+func (f *fakeDeployer) Close()                                    {}
+
+// bytesFromString is a small helper used by tests to create buffers.
+func bytesFromString(s string) *bytes.Buffer { return bytes.NewBufferString(s) }