refactor: replace InitDB with New for database initialization in tests

Author: ToeiRei

cmd/keymaster/debug_test.go

@@ -13,9 +13,9 @@ import (
 
 func TestDebugAddAccount(t *testing.T) {
 	dbdsn := "file:TestDebugAddAccount?mode=memory&cache=shared"
-	// configure viper indirectly by calling db.InitDB (simulate setupTestDB)
-	if err := db.InitDB("sqlite", dbdsn); err != nil {
-		t.Fatalf("InitDB failed: %v", err)
+	// configure viper indirectly by calling db.New (simulate setupTestDB)
+	if _, err := db.New("sqlite", dbdsn); err != nil {
+		t.Fatalf("db.New failed: %v", err)
 	}
 	mgr := db.DefaultAccountManager()
 	if mgr == nil {

cmd/keymaster/main_cmd_test.go

@@ -61,8 +61,8 @@ func TestNewRootCmd_RegistersSubcommandsAndVersion(t *testing.T) {
 func TestRunParallelTasks_PrintsResultsAndLogs(t *testing.T) {
 	// Initialize i18n and in-memory DB so logging doesn't fail
 	i18n.Init("en")
-	if err := db.InitDB("sqlite", ":memory:"); err != nil {
-		t.Fatalf("db.InitDB failed: %v", err)
+	if _, err := db.New("sqlite", ":memory:"); err != nil {
+		t.Fatalf("db.New failed: %v", err)
 	}
 
 	// Prepare accounts

cmd/keymaster/main_deploy_test.go

@@ -14,8 +14,8 @@ import (
 
 func TestRunDeploymentForAccount_NoActiveSystemKey_ReturnsError(t *testing.T) {
 	i18n.Init("en")
-	if err := db.InitDB("sqlite", ":memory:"); err != nil {
-		t.Fatalf("db.InitDB failed: %v", err)
+	if _, err := db.New("sqlite", ":memory:"); err != nil {
+		t.Fatalf("db.New failed: %v", err)
 	}
 
 	acct := model.Account{ID: 1, Username: "u", Hostname: "h", Serial: 0}
@@ -27,8 +27,8 @@ func TestRunDeploymentForAccount_NoActiveSystemKey_ReturnsError(t *testing.T) {
 
 func TestRunDeploymentForAccount_MissingSerialKey_ReturnsError(t *testing.T) {
 	i18n.Init("en")
-	if err := db.InitDB("sqlite", ":memory:"); err != nil {
-		t.Fatalf("db.InitDB failed: %v", err)
+	if _, err := db.New("sqlite", ":memory:"); err != nil {
+		t.Fatalf("db.New failed: %v", err)
 	}
 
 	acct := model.Account{ID: 1, Username: "u", Hostname: "h", Serial: 999}

cmd/keymaster/main_test.go

@@ -39,7 +39,7 @@ func setupTestDB(t *testing.T) {
 
 	// Initialize i18n and the database
 	i18n.Init("en")
-	if err := db.InitDB("sqlite", dsn); err != nil {
+	if _, err := db.New("sqlite", dsn); err != nil {
 		t.Fatalf("Failed to initialize test database: %v", err)
 	}
 }

cmd/keymaster/transfer_cli_test.go

@@ -21,8 +21,8 @@ func (t *testDeployer) Close()                                    {}
 // TestTransferCLI_CreateAndAccept runs the `transfer create` then `transfer accept` CLI paths.
 func TestTransferCLI_CreateAndAccept(t *testing.T) {
 	// Use an isolated DB per test
-	if err := db.InitDB("sqlite", ":memory:"); err != nil {
-		t.Fatalf("InitDB failed: %v", err)
+	if _, err := db.New("sqlite", ":memory:"); err != nil {
+		t.Fatalf("db.New failed: %v", err)
 	}
 
 	tmpdir := t.TempDir()