allMatch is weird on empty list

Dominilk01 · web-flow · commit 9b192e75eed3 · 2026-03-29T01:25:45.000+01:00
diff --git a/api/src/main/java/me/tofaa/entitylib/ve/ViewerEngine.java b/api/src/main/java/me/tofaa/entitylib/ve/ViewerEngine.java
@@ -121,7 +121,7 @@ public void clearTracked() {
      * @return true if the user passed and did not fail any rules, false otherwise
      */
     public boolean canSpawnFor(User user, WrapperEntity entity) {
-        if (entity.getViewerRules().stream().allMatch(rule -> rule.shouldSee(user))) return true;
+        if (!entity.getViewerRules().isEmpty() && entity.getViewerRules().stream().allMatch(rule -> rule.shouldSee(user))) return true;
         return globalRules.stream().allMatch(rule -> rule.shouldSee(user));
     }
 

Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,7 @@ public void clearTracked() {`
`121`	`121`	`* @return true if the user passed and did not fail any rules, false otherwise`
`122`	`122`	`*/`
`123`	`123`	`public boolean canSpawnFor(User user, WrapperEntity entity) {`
`124`		`- if (entity.getViewerRules().stream().allMatch(rule -> rule.shouldSee(user))) return true;`
	`124`	`+ if (!entity.getViewerRules().isEmpty() && entity.getViewerRules().stream().allMatch(rule -> rule.shouldSee(user))) return true;`
`125`	`125`	`return globalRules.stream().allMatch(rule -> rule.shouldSee(user));`
`126`	`126`	`}`
`127`	`127`