improved readability by moving stuff around

* analyse went into its own TokenAnalyse class
* data holder classes were extracted as well
* added unit test for non trivial stuff in Attachment class

Author: Zabuzard

application/src/main/java/org/togetherjava/tjbot/features/moderation/scam/AnalyseResults.java

@@ -0,0 +1,105 @@
+package org.togetherjava.tjbot.features.moderation.scam;
+
+import javax.annotation.Nullable;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Objects;
+import java.util.StringJoiner;
+
+final class AnalyseResults {
+    private boolean pingsEveryone;
+    private boolean containsSuspiciousKeyword;
+    private boolean containsDollarSign;
+    private boolean onlyContainsUrls = true;
+    private final Collection<AnalyseUrlResult> urls = new ArrayList<>();
+
+    void addUrlResult(AnalyseUrlResult result) {
+        urls.add(result);
+    }
+
+    boolean hasUrl() {
+        return !urls.isEmpty();
+    }
+
+    boolean hasSuspiciousUrl() {
+        return urls.stream().anyMatch(url -> url.isSuspicious);
+    }
+
+    boolean areAllUrlsWithAttachments() {
+        return urls.stream().allMatch(url -> url.containedAttachment != null);
+    }
+
+    Collection<Attachment> getUrlAttachments() {
+        return urls.stream().map(url -> url.containedAttachment).filter(Objects::nonNull).toList();
+    }
+
+    boolean pingsEveryone() {
+        return pingsEveryone;
+    }
+
+    void markPingsEveryone() {
+        pingsEveryone = true;
+    }
+
+    boolean containsSuspiciousKeyword() {
+        return containsSuspiciousKeyword;
+    }
+
+    void markContainsSuspiciousKeyword() {
+        containsSuspiciousKeyword = true;
+    }
+
+    boolean containsDollarSign() {
+        return containsDollarSign;
+    }
+
+    void markContainsDollarSign() {
+        containsDollarSign = true;
+    }
+
+    boolean onlyContainsUrls() {
+        return onlyContainsUrls;
+    }
+
+    void markNonUrlTokenFound() {
+        onlyContainsUrls = false;
+    }
+
+    @Override
+    public String toString() {
+        return new StringJoiner(", ", AnalyseResults.class.getSimpleName() + "[", "]")
+            .add("pingsEveryone=" + pingsEveryone)
+            .add("containsSuspiciousKeyword=" + containsSuspiciousKeyword)
+            .add("containsDollarSign=" + containsDollarSign)
+            .add("onlyContainsUrls=" + onlyContainsUrls)
+            .add("urls=" + urls)
+            .toString();
+    }
+
+    static final class AnalyseUrlResult {
+        private boolean isSuspicious;
+        @Nullable
+        private Attachment containedAttachment;
+
+        @Override
+        public String toString() {
+            return new StringJoiner(", ", AnalyseUrlResult.class.getSimpleName() + "[", "]")
+                .add("isSuspicious=" + isSuspicious)
+                .add("containedAttachment=" + containedAttachment)
+                .toString();
+        }
+
+        boolean isSuspicious() {
+            return isSuspicious;
+        }
+
+        void markSuspicious() {
+            isSuspicious = true;
+        }
+
+        void setContainedAttachment(Attachment containedAttachment) {
+            this.containedAttachment = containedAttachment;
+        }
+    }
+}

application/src/main/java/org/togetherjava/tjbot/features/moderation/scam/Attachment.java

@@ -0,0 +1,34 @@
+package org.togetherjava.tjbot.features.moderation.scam;
+
+import net.dv8tion.jda.api.entities.Message;
+
+import java.util.Optional;
+import java.util.Set;
+
+record Attachment(String fileName) {
+    private static final Set<String> IMAGE_EXTENSIONS =
+            Set.of("jpg", "jpeg", "png", "gif", "webp", "tiff", "svg", "apng");
+
+    boolean isImage() {
+        return getFileExtension().map(IMAGE_EXTENSIONS::contains).orElse(false);
+    }
+
+    private Optional<String> getFileExtension() {
+        int dot = fileName.lastIndexOf('.');
+        if (dot == -1) {
+            return Optional.empty();
+        }
+        String extension = fileName.substring(dot + 1);
+        return Optional.of(extension);
+    }
+
+    static Attachment fromDiscord(Message.Attachment attachment) {
+        return new Attachment(attachment.getFileName());
+    }
+
+    static Attachment fromUrlPath(String urlPath) {
+        int fileNameStart = urlPath.lastIndexOf('/');
+        String fileName = fileNameStart == -1 ? "" : urlPath.substring(fileNameStart + 1);
+        return new Attachment(fileName);
+    }
+}