Fixed another false positive (#1219)

Author: Zabuzard

application/config.json.template

@@ -44,7 +44,6 @@
             "hack",
             "steamcommunity",
             "freenitro",
-            "usd",
             "^earn",
             ".exe"
         ],

application/src/main/java/org/togetherjava/tjbot/features/moderation/scam/ScamDetector.java

@@ -67,7 +67,7 @@ private void analyzeToken(String token, AnalyseResults results) {
             results.containsSuspiciousKeyword = true;
         }
 
-        if (!results.containsDollarSign && token.contains("$")) {
+        if (!results.containsDollarSign && (token.contains("$") || "usd".equalsIgnoreCase(token))) {
             results.containsDollarSign = true;
         }
 

application/src/test/java/org/togetherjava/tjbot/features/moderation/scam/ScamDetectorTest.java

@@ -26,10 +26,10 @@ void setUp() {
         ScamBlockerConfig scamConfig = mock(ScamBlockerConfig.class);
         when(config.getScamBlocker()).thenReturn(scamConfig);
 
-        when(scamConfig.getSuspiciousKeywords()).thenReturn(Set.of("nitro", "boob", "sexy", "sexi",
-                "esex", "steam", "gift", "onlyfans", "bitcoin", "btc", "promo", "trader", "trading",
-                "whatsapp", "crypto", "claim", "teen", "adobe", "hack", "steamcommunity",
-                "freenitro", "usd", "^earn", ".exe"));
+        when(scamConfig.getSuspiciousKeywords())
+            .thenReturn(Set.of("nitro", "boob", "sexy", "sexi", "esex", "steam", "gift", "onlyfans",
+                    "bitcoin", "btc", "promo", "trader", "trading", "whatsapp", "crypto", "claim",
+                    "teen", "adobe", "hack", "steamcommunity", "freenitro", "^earn", ".exe"));
         when(scamConfig.getHostWhitelist()).thenReturn(Set.of("discord.com", "discord.media",
                 "discordapp.com", "discordapp.net", "discordstatus.com"));
         when(scamConfig.getHostBlacklist()).thenReturn(Set.of("bit.ly", "discord.gg", "teletype.in",
@@ -243,6 +243,8 @@ private static List<String> provideRealScamMessages() {
     private static List<String> provideRealFalsePositiveMessages() {
         return List
             .of("""
-                    https://learn.microsoft.com/en-us/dotnet/csharp/fundamentals/types/anonymous-types""");
+                    https://learn.microsoft.com/en-us/dotnet/csharp/fundamentals/types/anonymous-types""",
+                    """
+                            And according to quick google search. Median wage is about $23k usd""");
     }
 }