Database setup

[AzatothTheAwakened]

As already asked and suggested in #4 there is a need to define what Databse and DB-Accessor will be used.
My suggestion would be To use SQLite and JOOQ.
SQLite needs almost no setup and thus makes the bot more accessible for newer people.
On top of that JOOQ makes the Database exchangable and abstracts raw SQL.
Yet JOOQ code is still pretty close to plain SQL which makes it again good for beginners learning SQL.

We definetly need some more feedback on frameworks and libraries. Maybe someone else knows a better combo.

[acathers]

The database really doesn't matter that much, but I would prefer to use Hibernate since it's an in demand skill that is heavily used in Spring. Using hibernate you can use pretty much any database you'd like and setup is minimal.

[I-Al-Istannen]

Hibernate is pretty far from writing SQL. If you want to learn SQL, JOOQ is probably quite a bit better.

It is quite a bit simpler to use hibernate though, so maybe it is better suited for beginners?

If you go the JOOQ route, you can also easily manage the schema with Flyway, with Hibernate that is a bit more fun, if I am not misinformed.

Not quite sure

[SeaLife]

I recommend to use Spring Data JPA

[nxtk]

sqlite and jooq seems like a reasonable choice, just the right amount of complexity to be useful experience for a new contributors aswell, unlike jpa enterprise black magic monstrosity

[phydesmith]

Was there a final decision on how this was going to be implemented? I’d like to learn how the process works.

[acathers]

Was there a final decision on how this was going to be implemented? I’d like to learn how the process works.

Leslie said Thursday would be the decision.

[AzatothTheAwakened]

so 3 people people (including me) voted for jooq. So I think we should go with that, Im sorry to the others.

But please implement any data access as Repository to make the dataaccess (jooq) exchangable.
Repositories should be tested. Also extract interfaces from the repositories and work with dependency injection (constructor injection).

[thmalek]

Just found out about this, I may be a little late for the party, but here are my thoughts:

Spring is the industry standard and there is no debate about this, moving the project to Spring would be a huge plus. (but please, no XML BS.. #annotations)

About the database, if you want something portable, H2 is by far the best.. Fully supported by Spring Data/JPA, also, it has an awesome webconsole embedded if the user wants to do stuff more visually.

[SeaLife]

I'm also on the Spring-Train. There are a ton advantages you get by using Spring. But @thmalek i know someone is against Spring because its doing to much "magic".

+1 Spring
-1 any other DB-Access methods

[AzatothTheAwakened]

So we want to integrate a huuuge framework just to automate some very basic queries?
For example this does not really look like much work:
https://github.com/Together-Java/TjBot/blob/72e957ea7a6fd3f938c260677c5bbf1dc1c4ebe1/src/main/java/org/togetherjava/discordbot/db/repositories/ExampleRepository.java

[thmalek]

The thing about Spring is that you won't be only using it for querying the database, there are other features like DI/IOC. Even if you pretend to exclusively do very simple CRUD operations (which is not the case), Spring still a good idea.

Let's suppose that the community grows and now we have 50k members. Dealing with all modmail and reports through discord chat would be a mess, Spring MVC or WebFlux is one dependency away and your current code is already fully compatible.