test: Add "infer" CI check to github, remove from circle.

This now uses our own built image with the current master of infer.

Author: iphydf

.circleci/config.yml

@@ -16,7 +16,6 @@ workflows:
       # Static analysis
       - clang-analyze
       - cpplint
-      - infer
       - static-analysis
 
 jobs:
@@ -102,27 +101,6 @@ jobs:
       - run: git submodule update --init --recursive
       - run: CC=clang .circleci/cmake-ubsan
 
-  infer:
-    working_directory: ~/work
-    docker:
-      - image: toxchat/infer
-
-    steps:
-      - run: *apt_install
-      - checkout
-      - run: git submodule update --init --recursive
-      - run: infer --no-progress-bar -- cc
-          auto_tests/auto_test_support.c
-          auto_tests/lossless_packet_test.c
-          testing/misc_tools.c
-          toxav/*.c
-          toxcore/*.c
-          toxcore/*/*.c
-          toxencryptsave/*.c
-          third_party/cmp/*.c
-          -lpthread
-          $(pkg-config --cflags --libs libsodium opus vpx)
-
   static-analysis:
     working_directory: ~/work
     docker:

.github/workflows/ci.yml

@@ -16,7 +16,7 @@ jobs:
   analysis:
     strategy:
       matrix:
-        tool: [autotools, clang-tidy, compcert, cppcheck, doxygen, misra, tcc, tokstyle]
+        tool: [autotools, clang-tidy, compcert, cppcheck, doxygen, infer, misra, tcc, tokstyle]
     runs-on: ubuntu-latest
     steps:
       - name: Set up Docker Buildx

.gitignore

@@ -93,4 +93,5 @@ cscope.files
 # rpm
 tox.spec
 
+/infer
 .idea/

other/analysis/run-infer

@@ -1 +1 @@
-6d2321d58fa948279b28ae28a888672164eadaa985c43ce99ed0b71a69033c5c  /usr/local/bin/tox-bootstrapd
+870f1e19aa3f3f802c7e53af3848df6a0f7af9ad4c98213aa1578fa325b30fad  /usr/local/bin/tox-bootstrapd

other/bootstrap_daemon/docker/tox-bootstrapd.sha256

@@ -0,0 +1,41 @@
+FROM toxchat/infer:latest
+
+COPY toxav/ /work/c-toxcore/toxav/
+COPY toxcore/ /work/c-toxcore/toxcore/
+COPY toxencryptsave/ /work/c-toxcore/toxencryptsave/
+COPY third_party/ /work/c-toxcore/third_party/
+RUN infer capture -- clang++ -fsyntax-only \
+  $(pkg-config --cflags libconfig libsodium opus vpx) \
+  /work/c-toxcore/toxav/*.c \
+  /work/c-toxcore/toxcore/*.c \
+  /work/c-toxcore/toxcore/*/*.c \
+  /work/c-toxcore/toxencryptsave/*.c
+RUN ["infer", "analyze",\
+ "--report-console-limit", "100",\
+ "--jobs", "8",\
+ "--no-bufferoverrun",\
+ "--no-datalog",\
+ "--print-active-checkers",\
+ "--loop-hoisting",\
+ "--quandary",\
+ "--racerd",\
+ "--starvation",\
+ "--uninit",\
+ "--disable-issue-type", "BUFFER_OVERRUN_L2",\
+ "--disable-issue-type", "PULSE_UNNECESSARY_COPY",\
+ "--enable-issue-type", "EXPENSIVE_EXECUTION_TIME",\
+ "--enable-issue-type", "INVARIANT_CALL",\
+ "--enable-issue-type", "PULSE_UNINITIALIZED_CONST",\
+ "--enable-issue-type", "SENSITIVE_DATA_FLOW",\
+ "--enable-issue-type", "UNTRUSTED_BUFFER_ACCESS",\
+ "--enable-issue-type", "UNTRUSTED_HEAP_ALLOCATION",\
+ "--disable-issue-type", "USE_AFTER_FREE_LATENT",\
+ "--disable-issue-type", "STACK_VARIABLE_ADDRESS_ESCAPE",\
+ "--disable-issue-type", "INVARIANT_CALL",\
+ "--fail-on-issue"]
+# In the above, the first 2 are disabled for extreme sensitivity and false
+# positives, the ones at the end are probably decent, but have some false
+# positives, so we can't fail-on-issue with them on.
+# INVARIANT_CALL is pretty fun, but currently wrong, because it can't see
+# through potential mutations via callbacks. Our code is bad and we should
+# feel bad, but until that's fixed, the invariant checker doesn't work.

other/docker/infer/Dockerfile

@@ -0,0 +1,5 @@
+#!/bin/sh
+
+set -eux
+BUILD=infer
+docker build -t "toxchat/c-toxcore:$BUILD" -f "other/docker/$BUILD/Dockerfile" .

other/docker/infer/run

@@ -106,8 +106,9 @@ uint16_t rb_size(const RingBuffer *b)
 uint16_t rb_data(const RingBuffer *b, void **dest)
 {
     uint16_t i;
+    const uint16_t size = rb_size(b);
 
-    for (i = 0; i < rb_size(b); ++i) {
+    for (i = 0; i < size; ++i) {
         dest[i] = b->data[(b->start + i) % b->size];
     }
 

toxav/ring_buffer.c

@@ -290,8 +290,9 @@ static TCP_con *get_tcp_connection(const TCP_Connections *tcp_c, int tcp_connect
 uint32_t tcp_connected_relays_count(const TCP_Connections *tcp_c)
 {
     uint32_t count = 0;
+    const uint32_t size = tcp_connections_count(tcp_c);
 
-    for (uint32_t i = 0; i < tcp_connections_count(tcp_c); ++i) {
+    for (uint32_t i = 0; i < size; ++i) {
         const TCP_con *tcp_con = get_tcp_connection(tcp_c, i);
 
         if (tcp_con == nullptr) {

toxcore/TCP_connection.c

@@ -6211,6 +6211,39 @@ static bool handle_gc_lossless_packet(const GC_Session *c, GC_Chat *chat, const
     return true;
 }
 
+non_null(1, 2, 3, 4, 6) nullable(8)
+static int handle_gc_lossy_packet_decoded(
+    const GC_Session *c, GC_Chat *chat, GC_Connection *gconn, const GC_Peer *peer,
+    uint8_t packet_type, const uint8_t *data, uint16_t payload_len, void *userdata)
+{
+    switch (packet_type) {
+        case GP_MESSAGE_ACK: {
+            return handle_gc_message_ack(chat, gconn, data, payload_len);
+        }
+
+        case GP_PING: {
+            return handle_gc_ping(chat, gconn, data, payload_len);
+        }
+
+        case GP_INVITE_RESPONSE_REJECT: {
+            return handle_gc_invite_response_reject(c, chat, data, payload_len, userdata);
+        }
+
+        case GP_CUSTOM_PACKET: {
+            return handle_gc_custom_packet(c, chat, peer, data, payload_len, false, userdata);
+        }
+
+        case GP_CUSTOM_PRIVATE_PACKET: {
+            return handle_gc_custom_private_packet(c, chat, peer, data, payload_len, false, userdata);
+        }
+
+        default: {
+            LOGGER_WARNING(chat->log, "Warning: handling invalid lossy group packet type 0x%02x", packet_type);
+            return -1;
+        }
+    }
+}
+
 /** @brief Handles lossy groupchat message packets.
  *
  * This function assumes the length has already been validated.
@@ -6259,41 +6292,7 @@ static bool handle_gc_lossy_packet(const GC_Session *c, GC_Chat *chat, const uin
         return false;
     }
 
-    int ret = -1;
-    const uint16_t payload_len = (uint16_t)len;
-
-    switch (packet_type) {
-        case GP_MESSAGE_ACK: {
-            ret = handle_gc_message_ack(chat, gconn, data, payload_len);
-            break;
-        }
-
-        case GP_PING: {
-            ret = handle_gc_ping(chat, gconn, data, payload_len);
-            break;
-        }
-
-        case GP_INVITE_RESPONSE_REJECT: {
-            ret = handle_gc_invite_response_reject(c, chat, data, payload_len, userdata);
-            break;
-        }
-
-        case GP_CUSTOM_PACKET: {
-            ret = handle_gc_custom_packet(c, chat, peer, data, payload_len, false, userdata);
-            break;
-        }
-
-        case GP_CUSTOM_PRIVATE_PACKET: {
-            ret = handle_gc_custom_private_packet(c, chat, peer, data, payload_len, false, userdata);
-            break;
-        }
-
-        default: {
-            LOGGER_WARNING(chat->log, "Warning: handling invalid lossy group packet type 0x%02x", packet_type);
-            free(data);
-            return false;
-        }
-    }
+    const int ret = handle_gc_lossy_packet_decoded(c, chat, gconn, peer, packet_type, data, (uint16_t)len, userdata);
 
     free(data);