Skip to content

Commit 4f4220a

Browse files
JFreegmanzoff99
authored andcommitted
fix: a few off by one errors in group autotests
Since we're nul terminating these buffers they need one extra byte
1 parent 12fab0c commit 4f4220a

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

auto_tests/group_moderation_test.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,13 @@
1919
#define GROUP_NAME_LEN (sizeof(GROUP_NAME) - 1)
2020

2121
typedef struct Peer {
22-
char name[TOX_MAX_NAME_LENGTH];
22+
char name[TOX_MAX_NAME_LENGTH + 1];
2323
size_t name_length;
2424
uint32_t peer_id;
2525
} Peer;
2626

2727
typedef struct State {
28-
char self_name[TOX_MAX_NAME_LENGTH];
28+
char self_name[TOX_MAX_NAME_LENGTH + 1];
2929
size_t self_name_length;
3030

3131
uint32_t group_number;

auto_tests/group_state_test.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ static int check_group_state(const Tox *tox, uint32_t groupnumber, uint32_t peer
179179
if (password != nullptr && my_pass_len > 0) {
180180
ck_assert(my_pass_len <= TOX_GROUP_MAX_PASSWORD_SIZE);
181181

182-
uint8_t my_pass[TOX_GROUP_MAX_PASSWORD_SIZE];
182+
uint8_t my_pass[TOX_GROUP_MAX_PASSWORD_SIZE + 1];
183183
tox_group_get_password(tox, groupnumber, my_pass, &query_err);
184184
my_pass[my_pass_len] = 0;
185185
ck_assert_msg(query_err == TOX_ERR_GROUP_STATE_QUERIES_OK, "Failed to get password: %d", query_err);
@@ -199,7 +199,7 @@ static int check_group_state(const Tox *tox, uint32_t groupnumber, uint32_t peer
199199

200200
ck_assert(my_gname_len <= TOX_GROUP_MAX_GROUP_NAME_LENGTH);
201201

202-
uint8_t my_gname[TOX_GROUP_MAX_GROUP_NAME_LENGTH];
202+
uint8_t my_gname[TOX_GROUP_MAX_GROUP_NAME_LENGTH + 1];
203203
tox_group_get_name(tox, groupnumber, my_gname, &query_err);
204204
my_gname[my_gname_len] = 0;
205205

0 commit comments

Comments
 (0)