fix: toxav rtp temp buffer allocation size was too large

Green-Sky · Green-Sky · commit 671b1f92332a · 2024-09-17T19:39:38.000+02:00
and cast from 32bit to 16bit, causing a overflow and making the
allocated size too small
diff --git a/toxav/rtp.c b/toxav/rtp.c
@@ -805,7 +805,7 @@ int rtp_send_data(RTPSession *session, const uint8_t *data, uint32_t length,
         header.flags |= RTP_KEY_FRAME;
     }
 
-    const uint16_t rdata_size = length + RTP_HEADER_SIZE + 1;
+    const uint16_t rdata_size = min_u32(length + RTP_HEADER_SIZE + 1, MAX_CRYPTO_DATA_SIZE);
     VLA(uint8_t, rdata, rdata_size);
     memset(rdata, 0, rdata_size);
     rdata[0] = session->payload_type;  // packet id == payload_type

Original file line number	Diff line number	Diff line change
`@@ -805,7 +805,7 @@ int rtp_send_data(RTPSession session, const uint8_t data, uint32_t length,`
`805`	`805`	`header.flags \|= RTP_KEY_FRAME;`
`806`	`806`	`}`
`807`	`807`
`808`		`- const uint16_t rdata_size = length + RTP_HEADER_SIZE + 1;`
	`808`	`+ const uint16_t rdata_size = min_u32(length + RTP_HEADER_SIZE + 1, MAX_CRYPTO_DATA_SIZE);`
`809`	`809`	`VLA(uint8_t, rdata, rdata_size);`
`810`	`810`	`memset(rdata, 0, rdata_size);`
`811`	`811`	`rdata[0] = session->payload_type; // packet id == payload_type`