squash, tox_iteration_interval(...) must be inside lock

Author: sudden6

auto_tests/toxav_mt_test.cc

@@ -264,6 +264,8 @@ class AV_State {
 
   void tox_iterator() {
     while (!stop_threads_.load()) {
+      uint32_t sleep_ms = 0;
+
       // Perform this block only while loop lock is held
       {
         std::lock_guard<std::mutex> lock(tox_loop_lock_);
@@ -310,9 +312,12 @@ class AV_State {
             in_call_.store(false);
           }
         }
+
+        // WARNING: This accesses the Tox struct, so it must be inside the lock
+        tox_iteration_interval(tox_.get());
       }
 
-      std::this_thread::sleep_for(std::chrono::milliseconds(tox_iteration_interval(tox_.get())));
+      std::this_thread::sleep_for(std::chrono::milliseconds(sleep_ms));
     }
   }