cleanup: Remove useless if clause

JFreegman · JFreegman · commit fa201681e188 · 2024-03-28T11:34:40.000-04:00
diff --git a/toxcore/Messenger.c b/toxcore/Messenger.c
@@ -2468,14 +2468,12 @@ static void do_friends(Messenger *m, void *userdata)
             }
         }
 
-        if (m->friendlist[i].status == FRIEND_REQUESTED
-                || m->friendlist[i].status == FRIEND_CONFIRMED) { /* friend is not online. */
-            if (m->friendlist[i].status == FRIEND_REQUESTED) {
-                /* If we didn't connect to friend after successfully sending him a friend request the request is deemed
-                 * unsuccessful so we set the status back to FRIEND_ADDED and try again.
-                 */
-                check_friend_request_timed_out(m, i, temp_time, userdata);
-            }
+        if (m->friendlist[i].status == FRIEND_REQUESTED) {
+            /* If we didn't connect to friend after successfully sending him a friend
+             * request the request is deemed unsuccessful so we set the status back to
+             * FRIEND_ADDED and try again.
+             */
+            check_friend_request_timed_out(m, i, temp_time, userdata);
         }
 
         if (m->friendlist[i].status == FRIEND_ONLINE) { /* friend is online. */

Original file line number	Diff line number	Diff line change
`@@ -2468,14 +2468,12 @@ static void do_friends(Messenger m, void userdata)`
`2468`	`2468`	`}`
`2469`	`2469`	`}`
`2470`	`2470`
`2471`		`- if (m->friendlist[i].status == FRIEND_REQUESTED`
`2472`		`- \|\| m->friendlist[i].status == FRIEND_CONFIRMED) { /* friend is not online. */`
`2473`		`- if (m->friendlist[i].status == FRIEND_REQUESTED) {`
`2474`		`- /* If we didn't connect to friend after successfully sending him a friend request the request is deemed`
`2475`		`- * unsuccessful so we set the status back to FRIEND_ADDED and try again.`
`2476`		`- */`
`2477`		`- check_friend_request_timed_out(m, i, temp_time, userdata);`
`2478`		`- }`
	`2471`	`+ if (m->friendlist[i].status == FRIEND_REQUESTED) {`
	`2472`	`+ /* If we didn't connect to friend after successfully sending him a friend`
	`2473`	`+ * request the request is deemed unsuccessful so we set the status back to`
	`2474`	`+ * FRIEND_ADDED and try again.`
	`2475`	`+ */`
	`2476`	`+ check_friend_request_timed_out(m, i, temp_time, userdata);`
`2479`	`2477`	`}`
`2480`	`2478`
`2481`	`2479`	`if (m->friendlist[i].status == FRIEND_ONLINE) { /* friend is online. */`