Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.09%. Comparing base (7cefa93) to head (0cf065c).

@@            Coverage Diff             @@
##           master    #2688      +/-   ##
==========================================
+ Coverage   72.06%   72.09%   +0.02%     
==========================================
  Files         159      159              
  Lines       31305    31309       +4     
==========================================
+ Hits        22561    22571      +10     
+ Misses       8744     8738       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

One of the call sites also has this comment:

One of the call sites also has this comment:

c-toxcore/toxcore/DHT.c

Lines 682 to 684 in 206ea35

	// TODO(zugz): this could be made significantly more efficient by
	// using a version of add_to_list which works with a sorted list.
	add_to_list(nodes_list, MAX_SENT_NODES, client->public_key, &ipptp->ip_port, public_key);

That would make it O(log n). We're faster now, because it's O(n), but we could be even faster.

One of the call sites also has this comment:

c-toxcore/toxcore/DHT.c

Lines 682 to 684 in 206ea35

	// TODO(zugz): this could be made significantly more efficient by
	// using a version of add_to_list which works with a sorted list.
	add_to_list(nodes_list, MAX_SENT_NODES, client->public_key, &ipptp->ip_port, public_key);

That would make it O(log n). We're faster now, because it's O(n), but we could be even faster.

Hmm right. Let's just leave the TODO as is then.