cleanup: Remove all star imports. #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7.3M -> 4.8M for the JNI library.
These were for testing, but aren't terribly useful.
iphydf
force-pushed
the
no-star-import
branch
from
5238f83 to
5659cbd
Compare
It's clearer to have explicit imports.
iphydf
force-pushed
the
no-star-import
branch
from
5659cbd to
0e5a23d
Compare
robinlinden
approved these changes
Feb 21, 2024
Member
robinlinden
left a comment
robinlinden
left a comment
There was a problem hiding this comment.
In aTox I use ktlint to enforce a bunch of things like this.
https://pinterest.github.io/ktlint/0.49.1/rules/standard/#no-wildcard-imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's clearer to have explicit imports.
This change is