chore: Only require jni.h to be found when searching for the JNI #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinlinden
changed the title
auto-add-label
bot
added
the
chore
Before this patch, we would only add the jni.h include path if both JNI and AWT were found as FindJNI.cmake only sets JNI_FOUND if both JNI and AWT were found, requiring you to install openjdk-11-jdk instead of openjdk-11-jdk-headless for the build to succeed. After this patch both the headless and the full jdk is fine. See: https://cmake.org/cmake/help/v3.22/module/FindJNI.html
robinlinden
force-pushed
the
allow-headless-build
branch
from
1b87350 to
5003b0d
Compare
JFreegman
approved these changes
Jan 7, 2022
Member
JFreegman
left a comment
JFreegman
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, we would only add the jni.h include path if both JNI
and AWT were found as FindJNI.cmake only sets JNI_FOUND if both JNI and
AWT were found, requiring you to install openjdk-11-jdk instead of
openjdk-11-jdk-headless for the build to succeed.
After this patch both the headless and the full jdk is fine.
See: https://cmake.org/cmake/help/v3.22/module/FindJNI.html
This change is