Disable KeyTyped events from SharpHook

GH-107

Author: TolikPylypchuk

src/KeyboardSwitch.Core/Services/Hook/SharpHookService.cs

@@ -30,13 +30,15 @@ internal sealed class SharpHookService : DisposableService, IKeyboardHookService
     public SharpHookService(
         IReactiveGlobalHook hook,
         IScheduler scheduler,
+        IGlobalHookProvider globalHookProvider,
         IAccessibilityProvider accessibilityProvider,
         ILogger<SharpHookService> logger)
     {
         this.hook = hook;
         this.scheduler = scheduler;
         this.logger = logger;
 
+        globalHookProvider.KeyTypedEnabled = false;
         accessibilityProvider.AxPollFrequency = AxPollFrequencySeconds;
 
         this.hook.HookEnabled.Subscribe(e => this.logger.LogInformation("Created a global keyboard hook"));

test/KeyboardSwitch.Tests/Services/SharpHookServiceTests.cs

@@ -33,9 +33,10 @@ public void ModifiersOnce(List<SingleModifier> modifiers, WaitTime waitTime)
 
         using var hook = new TestGlobalHook();
         var scheduler = new TestScheduler();
+        var provider = new TestProvider();
 
         using var service = new SharpHookService(
-            new ReactiveGlobalHookAdapter(hook, scheduler), scheduler, new TestProvider(), this.logger);
+            new ReactiveGlobalHookAdapter(hook, scheduler), scheduler, provider, provider, this.logger);
 
         var observer = scheduler.CreateObserver<EventMask>();
         service.HotKeyPressed.Subscribe(observer);
@@ -64,9 +65,10 @@ public void ModifiersMultiple(List<SingleModifier> modifiers, PressCount pressCo
 
         using var hook = new TestGlobalHook();
         var scheduler = new TestScheduler();
+        var provider = new TestProvider();
 
         using var service = new SharpHookService(
-            new ReactiveGlobalHookAdapter(hook, scheduler), scheduler, new TestProvider(), this.logger);
+            new ReactiveGlobalHookAdapter(hook, scheduler), scheduler, provider, provider, this.logger);
 
         var observer = scheduler.CreateObserver<EventMask>();
         service.HotKeyPressed.Subscribe(observer);
@@ -100,9 +102,10 @@ public void ModifiersMultipleTooLong(List<SingleModifier> modifiers, PressCount
 
         using var hook = new TestGlobalHook();
         var scheduler = new TestScheduler();
+        var provider = new TestProvider();
 
         using var service = new SharpHookService(
-            new ReactiveGlobalHookAdapter(hook, scheduler), scheduler, new TestProvider(), this.logger);
+            new ReactiveGlobalHookAdapter(hook, scheduler), scheduler, provider, provider, this.logger);
 
         var observer = scheduler.CreateObserver<EventMask>();
         service.HotKeyPressed.Subscribe(observer);
@@ -136,9 +139,10 @@ public void OtherKeys(List<SingleModifier> modifiers, NonModifierKey key, WaitTi
 
         using var hook = new TestGlobalHook();
         var scheduler = new TestScheduler();
+        var provider = new TestProvider();
 
         using var service = new SharpHookService(
-            new ReactiveGlobalHookAdapter(hook, scheduler), scheduler, new TestProvider(), this.logger);
+            new ReactiveGlobalHookAdapter(hook, scheduler), scheduler, provider, provider, this.logger);
 
         var observer = scheduler.CreateObserver<EventMask>();
         service.HotKeyPressed.Subscribe(observer);
@@ -164,9 +168,10 @@ public void OnlyKeyUp(List<SingleModifier> modifiers, WaitTime waitTime)
 
         using var hook = new TestGlobalHook();
         var scheduler = new TestScheduler();
+        var provider = new TestProvider();
 
         using var service = new SharpHookService(
-            new ReactiveGlobalHookAdapter(hook, scheduler), scheduler, new TestProvider(), this.logger);
+            new ReactiveGlobalHookAdapter(hook, scheduler), scheduler, provider, provider, this.logger);
 
         var observer = scheduler.CreateObserver<EventMask>();
         service.HotKeyPressed.Subscribe(observer);
@@ -196,9 +201,10 @@ public void KeyDownTooLong(List<SingleModifier> modifiers, WaitTime waitTime)
 
         using var hook = new TestGlobalHook();
         var scheduler = new TestScheduler();
+        var provider = new TestProvider();
 
         using var service = new SharpHookService(
-            new ReactiveGlobalHookAdapter(hook, scheduler), scheduler, new TestProvider(), this.logger);
+            new ReactiveGlobalHookAdapter(hook, scheduler), scheduler, provider, provider, this.logger);
 
         var observer = scheduler.CreateObserver<EventMask>();
         service.HotKeyPressed.Subscribe(observer);
@@ -227,9 +233,10 @@ public void KeyDownRepeated(List<SingleModifier> modifiers, WaitTime waitTime)
 
         using var hook = new TestGlobalHook();
         var scheduler = new TestScheduler();
+        var provider = new TestProvider();
 
         using var service = new SharpHookService(
-            new ReactiveGlobalHookAdapter(hook, scheduler), scheduler, new TestProvider(), this.logger);
+            new ReactiveGlobalHookAdapter(hook, scheduler), scheduler, provider, provider, this.logger);
 
         var observer = scheduler.CreateObserver<EventMask>();
         service.HotKeyPressed.Subscribe(observer);
@@ -261,9 +268,10 @@ public void UnregisterModifiers(List<SingleModifier> modifiers, WaitTime waitTim
 
         using var hook = new TestGlobalHook();
         var scheduler = new TestScheduler();
+        var provider = new TestProvider();
 
         using var service = new SharpHookService(
-            new ReactiveGlobalHookAdapter(hook, scheduler), scheduler, new TestProvider(), this.logger);
+            new ReactiveGlobalHookAdapter(hook, scheduler), scheduler, provider, provider, this.logger);
 
         var observer = scheduler.CreateObserver<EventMask>();
         service.HotKeyPressed.Subscribe(observer);
@@ -290,9 +298,10 @@ public void DisposeComplete()
 
         using var hook = new TestGlobalHook();
         var scheduler = new TestScheduler();
+        var provider = new TestProvider();
 
         var service = new SharpHookService(
-            new ReactiveGlobalHookAdapter(hook, scheduler), scheduler, new TestProvider(), this.logger);
+            new ReactiveGlobalHookAdapter(hook, scheduler), scheduler, provider, provider, this.logger);
 
         var observer = scheduler.CreateObserver<EventMask>();
         service.HotKeyPressed.Subscribe(observer);
@@ -314,9 +323,10 @@ public void Cancel()
 
         using var hook = new TestGlobalHook();
         var scheduler = new TestScheduler();
+        var provider = new TestProvider();
 
         using var service = new SharpHookService(
-            new ReactiveGlobalHookAdapter(hook, scheduler), scheduler, new TestProvider(), this.logger);
+            new ReactiveGlobalHookAdapter(hook, scheduler), scheduler, provider, provider, this.logger);
 
         // Act
 
@@ -331,23 +341,42 @@ public void Cancel()
         Assert.False(hook.IsRunning);
     }
 
+    [Fact(DisplayName = "SharpHookService should disable KeyTyped events")]
+    public void KeyTypedEvents()
+    {
+        // Arrange
+
+        using var hook = new TestGlobalHook();
+        var scheduler = new TestScheduler();
+        var provider = new TestProvider();
+
+        // Act
+
+        using var service = new SharpHookService(
+            new ReactiveGlobalHookAdapter(hook, scheduler), scheduler, provider, provider, this.logger);
+
+        // Assert
+
+        Assert.False(((IGlobalHookProvider)provider).KeyTypedEnabled);
+    }
+
     [Fact(DisplayName = "SharpHookService should set the poll frequency for the Accessibility API")]
     public void AccessibilityProvider()
     {
         // Arrange
 
         using var hook = new TestGlobalHook();
         var scheduler = new TestScheduler();
-        IAccessibilityProvider provider = new TestProvider();
+        var provider = new TestProvider();
 
         // Act
 
         using var service = new SharpHookService(
-            new ReactiveGlobalHookAdapter(hook, scheduler), scheduler, provider, this.logger);
+            new ReactiveGlobalHookAdapter(hook, scheduler), scheduler, provider, provider, this.logger);
 
         // Assert
 
-        Assert.Equal(SharpHookService.AxPollFrequencySeconds, provider.AxPollFrequency);
+        Assert.Equal(SharpHookService.AxPollFrequencySeconds, ((IAccessibilityProvider)provider).AxPollFrequency);
     }
 
     private void SimulateKeyEvents(