- Fixed some github/"codacy" issues.

Author: Tomenz

CommonLib/md5.cpp

@@ -290,7 +290,7 @@ void MD5::update(const unsigned char input[], size_type length)
 // for convenience provide a verson with signed char
 void MD5::update(const char input[], size_type length)
 {
-    update((const unsigned char*)input, length);
+    update(reinterpret_cast<const unsigned char*>(input), length);
 }
 
 //////////////////////////////
@@ -299,14 +299,14 @@ void MD5::update(const char input[], size_type length)
 // the message digest and zeroizing the context.
 MD5& MD5::finalize()
 {
-    static unsigned char padding[64] = {
-        0x80, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
-        0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
-        0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0
-    };
-
     if (!finalized)
     {
+        static unsigned char padding[64] = {
+            0x80, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+            0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
+            0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0
+        };
+
         // Save number of bits
         unsigned char bits[8];
         encode(bits, count, 8);

Http2Fetch.cpp

@@ -1,4 +1,4 @@
-// SockTest.cpp : Definiert den Einstiegspunkt für die Konsolenanwendung.
+// SockTest.cpp : Definiert den Einstiegspunkt f�r die Konsolenanwendung.
 //
 #include <iostream>
 #include <unordered_map>
@@ -120,17 +120,17 @@ int main(int argc, const char* argv[], char **envp)
         if ((itFound = find_if(begin(mapEnvList), end(mapEnvList), [](auto pr) { return (pr.first == L"CONTENT_TYPE") ? true : false;  })) != end(mapEnvList))
             strContentTyp = itFound->second;
 
-        wstring strHost;
-        if ((itFound = find_if(begin(mapEnvList), end(mapEnvList), [](auto pr) { return (pr.first == L"HTTP_HOST") ? true : false; })) != end(mapEnvList))
-            strHost = itFound->second;
+        //wstring strHost;
+        //if ((itFound = find_if(begin(mapEnvList), end(mapEnvList), [](auto pr) { return (pr.first == L"HTTP_HOST") ? true : false; })) != end(mapEnvList))
+        //    strHost = itFound->second;
 
-        wstring strHttps;
-        if ((itFound = find_if(begin(mapEnvList), end(mapEnvList), [](auto pr) { return (pr.first == L"HTTPS") ? true : false;  })) != end(mapEnvList))
-            strHttps = itFound->second;
+        //wstring strHttps;
+        //if ((itFound = find_if(begin(mapEnvList), end(mapEnvList), [](auto pr) { return (pr.first == L"HTTPS") ? true : false;  })) != end(mapEnvList))
+        //    strHttps = itFound->second;
 
-        wstring strQuery;
-        if ((itFound = find_if(begin(mapEnvList), end(mapEnvList), [](auto pr) { return (pr.first == L"QUERY_STRING") ? true : false;  })) != end(mapEnvList))
-            strQuery = itFound->second;
+        //wstring strQuery;
+        //if ((itFound = find_if(begin(mapEnvList), end(mapEnvList), [](auto pr) { return (pr.first == L"QUERY_STRING") ? true : false;  })) != end(mapEnvList))
+        //    strQuery = itFound->second;
 
         wstring strUrl;
         if ((itFound = find_if(begin(mapEnvList), end(mapEnvList), [](auto pr) { return (pr.first == L"PROXYURL") ? true : false;  })) != end(mapEnvList))
@@ -299,7 +299,7 @@ if (nPos != string::npos)
     fetch.AddToHeader("Accept-Encoding", "gzip, deflate, br");
     fetch.AddToHeader("Cache-Control", "no-cache");
 
-    fetch.AddToHeader("Accept-Language", "de,en-US;q=0.7,en;q=0.3");    // wird für elumatec.com benötigt
+    fetch.AddToHeader("Accept-Language", "de,en-US;q=0.7,en;q=0.3");    // wird f�r elumatec.com ben�tigt
     //fetch.AddToHeader("DNT", "1");
     //fetch.AddToHeader("Connection", "keep-alive");
     //fetch.AddToHeader("Connection", "close");

Http2Serv.cpp

@@ -48,7 +48,7 @@ void ReadConfiguration(const wstring& m_strModulePath, deque<CHttpServ>& m_vServ
     static const pair<wstring, int> strKeyWordMultiItems[] = { { L"RewriteRule",1 },{ L"AliasMatch",2 },{ L"ForceType",3 },{ L"FileTyps",4 },{ L"SetEnvIf",5 },{ L"RedirectMatch",6 },{ L"DeflateTyps",7 },{ L"Authenticate",8 },{ L"ScriptAliasMatch",9 },
                                                                { L"ScriptOptionsHdl",10 },{ L"AddHeader", 11 },{ L"ReverseProxy", 12},{ L"ScriptAuthHdl",13 } };
 
-    vector<wstring> vFileTypExt = conf.get(L"FileTyps");
+    //vector<wstring> vFileTypExt = conf.get(L"FileTyps");
 
     vector<wstring> vListen = conf.get(L"Listen");
     if (vListen.empty() == true)

MappedFile.cpp

@@ -61,7 +61,7 @@ bool MappedFile::open(const std::wstring& fileName)
         return false;
     }
 
-    mappedData = (const uint8_t *)MapViewOfFile(hMap, FILE_MAP_READ, 0, 0, fileSize);
+    mappedData = static_cast<const uint8_t*>(MapViewOfFile(hMap, FILE_MAP_READ, 0, 0, fileSize));
 
     /* We can call CloseHandle here, but it will not be closed until
      * we unmap the view */

Timer.h

@@ -17,6 +17,7 @@
 #include <atomic>
 #include <thread>
 #include <functional>
+#include <chrono>
 
 template<class T>
 class Timer