Skip to content

Commit da655d9

Browse files
authored
chore: use github-actions[bot] identity and SSH signing (#850)
* chore: use github-actions[bot] identity and SSH signing * chore: address security review - tighten SSH permissions and cleanup key * chore: remove default values from coderabbit config
1 parent b10b82e commit da655d9

File tree

2 files changed

+16
-10
lines changed

2 files changed

+16
-10
lines changed

.coderabbit.yaml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
22
---
33
reviews:
4-
profile: chill
5-
collapse_walkthrough: false
6-
sequence_diagrams: true
74
path_instructions:
85
- path: src/**/*.py
96
instructions: |
@@ -24,8 +21,3 @@ reviews:
2421
- Clear CLI argument handling
2522
- Proper error handling and user feedback
2623
- Consistent logging and output formatting
27-
tools:
28-
ruff:
29-
enabled: true
30-
yamllint:
31-
enabled: true

.github/workflows/release.yml

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,18 @@ jobs:
5252

5353
- name: Configure git
5454
run: |
55-
git config user.name "${{ github.actor }}"
56-
git config user.email "${{ github.actor }}@users.noreply.github.com"
55+
git config user.name "github-actions[bot]"
56+
git config user.email "41898282+github-actions[bot]@users.noreply.github.com"
57+
58+
- name: Setup SSH signing
59+
run: |
60+
mkdir -p ~/.ssh
61+
chmod 700 ~/.ssh
62+
echo "${{ secrets.SIGNING_KEY }}" > ~/.ssh/signing_key
63+
chmod 600 ~/.ssh/signing_key
64+
git config gpg.format ssh
65+
git config user.signingkey ~/.ssh/signing_key
66+
git config commit.gpgsign true
5767
5868
- name: Determine version and create changelog
5969
id: bumper
@@ -124,3 +134,7 @@ jobs:
124134
generate_release_notes: true
125135
})
126136
core.setOutput('html_url', response.data.html_url)
137+
138+
- name: Cleanup SSH signing key
139+
if: always()
140+
run: rm -f ~/.ssh/signing_key

0 commit comments

Comments
 (0)