fix: replace os.EOL with hardcoded newline for cross-platform compatibility (#809)

On Windows, os.EOL returns \r\n which causes test failures because
third-party libraries (marked, commitlint) normalize line endings to \n
internally. Since the bot runs on Lambda (Linux) and outputs GitHub
Markdown, \n is the correct line ending in all cases.

Closes #54

Signed-off-by: Tomer Figenblat <tomer@figenblat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

Author: TomerFi

.github/workflows/pr.yml

@@ -8,8 +8,11 @@ on:
 
 jobs:
   test:
-    runs-on: ubuntu-latest
-    name: Lint and test project
+    runs-on: ${{ matrix.os }}
+    name: Lint and test project (${{ matrix.os }})
+    strategy:
+      matrix:
+        os: [ubuntu-latest, windows-latest]
     steps:
       - name: Checkout sources
         uses: actions/checkout@v6
@@ -30,6 +33,7 @@ jobs:
         run: npm test
 
       - name: Upload coverage to Codecov
+        if: matrix.os == 'ubuntu-latest'
         uses: codecov/codecov-action@v5
         with:
           token: ${{ secrets.CODECOV_TOKEN }}

src/handlers/pr-conventional-commits.js

@@ -1,6 +1,6 @@
 import lint from '@commitlint/lint'
 import load from '@commitlint/load'
-import { EOL } from 'node:os'
+const EOL = '\n'
 
 /* example configuration (for reference):
 rules:

src/handlers/pr-conventional-title.js

@@ -1,6 +1,6 @@
 import lint from '@commitlint/lint'
 import load from '@commitlint/load'
-import { EOL } from 'node:os'
+const EOL = '\n'
 
 /* example configuration (for reference):
 rules:

src/handlers/pr-signed-commits.js

@@ -1,4 +1,4 @@
-import { EOL } from 'node:os'
+const EOL = '\n'
 import validator from 'validator';
 
 /* example configuration (for reference):

src/handlers/pr-tasks-list.js

@@ -1,5 +1,5 @@
 import { marked } from 'marked'
-import { EOL } from 'node:os'
+const EOL = '\n'
 
 const BOT_CHECK_URL = 'https://auto-me-bot.figenblat.com';
 const CHECK_NAME = 'Auto-Me-Bot Tasks List';

tests/handlers/pr-conventional-commits.test.js

@@ -2,7 +2,7 @@ import { expect, use as chaiUse  } from 'chai'
 import sinonChai from 'sinon-chai'
 import sinon from 'sinon'
 import { beforeEach } from 'mocha'
-import { EOL } from 'node:os'
+const EOL = '\n'
 
 chaiUse(sinonChai)
 

tests/handlers/pr-conventional-title.test.js

@@ -2,7 +2,7 @@ import { expect, use as chaiUse  } from 'chai'
 import sinonChai from 'sinon-chai'
 import sinon from 'sinon'
 import { beforeEach } from 'mocha'
-import { EOL } from 'node:os'
+const EOL = '\n'
 
 chaiUse(sinonChai)
 

tests/handlers/pr-signed-commits.test.js

@@ -2,7 +2,7 @@ import { expect, use as chaiUse  } from 'chai'
 import sinonChai from 'sinon-chai'
 import sinon from 'sinon'
 import { beforeEach } from 'mocha'
-import { EOL } from 'node:os'
+const EOL = '\n'
 import { cloneDeep } from 'lodash-es'
 
 chaiUse(sinonChai)

tests/handlers/pr-tasks-list.test.js

@@ -2,7 +2,7 @@ import { expect, use as chaiUse  } from 'chai'
 import sinonChai from 'sinon-chai'
 import sinon from 'sinon'
 import { beforeEach } from 'mocha'
-import { EOL } from 'node:os'
+const EOL = '\n'
 
 chaiUse(sinonChai)