Skip to content

Commit 230973e

Browse files
authored
Add scrollbars to docked widgets (#405)
1 parent bf73d4e commit 230973e

File tree

3 files changed

+15
-7
lines changed

3 files changed

+15
-7
lines changed

CHANGES.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@ Enhancements:
66
* Update default values in "Run DVC" tab #402
77

88
Bug fixes:
9+
* Add scrollbar to docked widgets #405
910
* Remove GPU size and GPU checkbox for volume render in settings #403
1011
* Add 3D viewer docking option in the settings #398
1112

12-
1313
## v24.1.1
1414
Bug fixes:
1515
* Fix abscissa order in graphs #372

src/idvc/dvc_interface.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ def __init__(self):
190190
self.CreateWorkingTempFolder()
191191

192192
#Load Settings:
193-
self.settings = QSettings("CCPi", "DVC Interface v24.0.1")
193+
self.settings = QSettings("CCPi", "DVC Interface v24.1.1")
194194

195195
if self.settings.value("copy_files"):
196196
self.copy_files = True
@@ -415,7 +415,7 @@ def CreateViewerSettingsPanel(self):
415415
formLayout.setWidget(widgetno, QFormLayout.FieldRole, vs_widgets['coords_warning_label'])
416416

417417
self.visualisation_setting_widgets = vs_widgets
418-
418+
419419
def updateCoordinates(self):
420420
viewers_2D = [self.vis_widget_2D.frame.viewer]
421421
vs_widgets = self.visualisation_setting_widgets
@@ -451,7 +451,7 @@ def CreateHelpPanel(self):
451451
452452
Saves the help text for all tabs.
453453
Adds a QLabel in the form of scrollable text."""
454-
help_panel = generateUIDockParameters(self, "Help")
454+
help_panel = generateUIDockParameters(self, "Help", scrollable = False)
455455
dockWidget = help_panel[0]
456456
dockWidget.setObjectName("HelpPanel")
457457
groupBox = help_panel[5]

src/idvc/utilities.py

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
from PySide2.QtGui import *
66
import numpy as np
77
import os
8+
from eqt.ui.NoBorderScrollArea import NoBorderScrollArea
89

910

1011

@@ -66,19 +67,21 @@ def __str__(self):
6667
n = "subvol_points {}".format(self.subvol_points)
6768
return "RunResults:\n{}\n{}".format(a , n)
6869

69-
def generateUIDockParameters(self, title): #copied from dvc_configurator.py
70+
71+
72+
def generateUIDockParameters(self, title, scrollable = True): #copied from dvc_configurator.py
7073
'''creates a dockable widget with a form layout group to add things to
7174
7275
basically you can add widget to the returned groupBoxFormLayout and paramsGroupBox
7376
The returned dockWidget must be added with
7477
self.addDockWidget(QtCore.Qt.RightDockWidgetArea, dockWidget)
78+
A scoll area can be added to the widget by setting the flag to True.
7579
'''
7680
dockWidget = QDockWidget(self)
7781
dockWidget.setFeatures(QDockWidget.NoDockWidgetFeatures)
7882
dockWidget.setWindowTitle(title)
7983
dockWidgetContents = QWidget()
8084

81-
8285
# Add vertical layout to dock contents
8386
dockContentsVerticalLayout = QVBoxLayout(dockWidgetContents)
8487
dockContentsVerticalLayout.setContentsMargins(0, 0, 0, 0)
@@ -101,7 +104,12 @@ def generateUIDockParameters(self, title): #copied from dvc_configurator.py
101104
# Add elements to layout
102105
internalWidgetVerticalLayout.addWidget(paramsGroupBox)
103106
dockContentsVerticalLayout.addWidget(internalDockWidget)
104-
dockWidget.setWidget(dockWidgetContents)
107+
108+
if scrollable == True:
109+
scrollArea = NoBorderScrollArea(dockWidgetContents)
110+
dockWidget.setWidget(scrollArea)
111+
else:
112+
dockWidget.setWidget(dockWidgetContents)
105113

106114
# self.graphWidgetVL.addWidget(self.graphParamsGroupBox)
107115
# self.graphDockVL.addWidget(self.dockWidget)

0 commit comments

Comments
 (0)