Skip to content

Commit a387e21

Browse files
committed
update topper
1 parent 53cee8c commit a387e21

File tree

6 files changed

+16
-47
lines changed

6 files changed

+16
-47
lines changed

plugin/src/main/java/me/hsgamer/topper/spigot/plugin/TopperPlugin.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,27 +12,24 @@
1212
import me.hsgamer.topper.spigot.plugin.config.MessageConfig;
1313
import me.hsgamer.topper.spigot.plugin.hook.HookSystem;
1414
import me.hsgamer.topper.spigot.plugin.listener.JoinListener;
15-
import me.hsgamer.topper.spigot.plugin.manager.NameProviderManager;
1615
import me.hsgamer.topper.spigot.plugin.manager.ValueProviderManager;
1716
import me.hsgamer.topper.spigot.plugin.template.SpigotStorageSupplierTemplate;
1817
import me.hsgamer.topper.spigot.plugin.template.SpigotTopTemplate;
1918
import org.bstats.bukkit.Metrics;
19+
import org.bukkit.Bukkit;
2020

2121
import java.util.Arrays;
2222
import java.util.List;
2323
import java.util.logging.Level;
2424

2525
public class TopperPlugin extends BasePlugin {
26-
public static final String GROUP = "topper";
27-
2826
@Override
2927
protected List<Object> getComponents() {
3028
return Arrays.asList(
3129
ConfigGenerator.newInstance(MainConfig.class, new BukkitConfig(this)),
3230
ConfigGenerator.newInstance(MessageConfig.class, new BukkitConfig(this, "messages.yml")),
3331

3432
new ValueProviderManager(),
35-
new NameProviderManager(),
3633

3734
new HookSystem(this),
3835

@@ -51,6 +48,7 @@ protected List<Object> getComponents() {
5148
@Override
5249
public void load() {
5350
MessageUtils.setPrefix(get(MessageConfig.class)::getPrefix);
51+
get(SpigotTopTemplate.class).getNameProviderManager().setDefaultNameProvider(uuid -> Bukkit.getOfflinePlayer(uuid).getName());
5452
}
5553

5654
@Override

plugin/src/main/java/me/hsgamer/topper/spigot/plugin/hook/lastloginapi/LastLoginAPIHook.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,8 @@
44
import com.alessiodp.lastloginapi.api.interfaces.LastLoginPlayer;
55
import io.github.projectunified.minelib.plugin.base.Loadable;
66
import me.hsgamer.topper.spigot.plugin.TopperPlugin;
7-
import me.hsgamer.topper.spigot.plugin.manager.NameProviderManager;
7+
import me.hsgamer.topper.spigot.plugin.template.SpigotTopTemplate;
88

9-
import java.util.Optional;
109
import java.util.UUID;
1110

1211
import static com.alessiodp.lastloginapi.api.LastLogin.getApi;
@@ -21,7 +20,7 @@ public LastLoginAPIHook(TopperPlugin plugin) {
2120

2221
@Override
2322
public void enable() {
24-
disableRunnable = plugin.get(NameProviderManager.class).addNameProvider(this::getName);
23+
disableRunnable = plugin.get(SpigotTopTemplate.class).getNameProviderManager().addNameProvider(this::getName);
2524
}
2625

2726
@Override
@@ -31,9 +30,10 @@ public void disable() {
3130
}
3231
}
3332

34-
private Optional<String> getName(UUID uuid) {
33+
private String getName(UUID uuid) {
3534
LastLoginAPI api = getApi();
3635
LastLoginPlayer player = api.getPlayer(uuid);
37-
return Optional.of(player.getName()).filter(name -> !name.isEmpty());
36+
String name = player.getName();
37+
return name.isEmpty() ? null : name;
3838
}
3939
}

plugin/src/main/java/me/hsgamer/topper/spigot/plugin/hook/luckperms/LuckPermsHook.java

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,11 @@
22

33
import io.github.projectunified.minelib.plugin.base.Loadable;
44
import me.hsgamer.topper.spigot.plugin.TopperPlugin;
5-
import me.hsgamer.topper.spigot.plugin.manager.NameProviderManager;
5+
import me.hsgamer.topper.spigot.plugin.template.SpigotTopTemplate;
66
import net.luckperms.api.LuckPerms;
77
import net.luckperms.api.LuckPermsProvider;
88
import net.luckperms.api.model.user.User;
99

10-
import java.util.Optional;
11-
1210
public class LuckPermsHook implements Loadable {
1311
private final TopperPlugin instance;
1412
private Runnable disableRunnable;
@@ -23,7 +21,13 @@ public void enable() {
2321
TopContextCalculator contextCalculator = new TopContextCalculator(instance);
2422
api.getContextManager().registerCalculator(contextCalculator);
2523

26-
Runnable unregisterNameProvider = instance.get(NameProviderManager.class).addNameProvider(uuid -> Optional.ofNullable(api.getUserManager().getUser(uuid)).map(User::getUsername));
24+
Runnable unregisterNameProvider = instance.get(SpigotTopTemplate.class).getNameProviderManager().addNameProvider(uuid -> {
25+
User user = api.getUserManager().getUser(uuid);
26+
if (user == null) {
27+
return null;
28+
}
29+
return user.getUsername();
30+
});
2731

2832
disableRunnable = () -> {
2933
api.getContextManager().unregisterCalculator(contextCalculator);

plugin/src/main/java/me/hsgamer/topper/spigot/plugin/manager/NameProviderManager.java

Lines changed: 0 additions & 27 deletions
This file was deleted.

plugin/src/main/java/me/hsgamer/topper/spigot/plugin/template/SpigotTopTemplate.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
import me.hsgamer.topper.spigot.plugin.TopperPlugin;
1212
import me.hsgamer.topper.spigot.plugin.config.MainConfig;
1313
import me.hsgamer.topper.spigot.plugin.event.GenericEntryUpdateEvent;
14-
import me.hsgamer.topper.spigot.plugin.manager.NameProviderManager;
1514
import me.hsgamer.topper.spigot.plugin.manager.ValueProviderManager;
1615
import me.hsgamer.topper.spigot.query.forward.plugin.PluginContext;
1716
import me.hsgamer.topper.storage.core.DataStorage;
@@ -50,11 +49,6 @@ public Optional<ValueProvider<UUID, Double>> createValueProvider(Map<String, Obj
5049
return plugin.get(ValueProviderManager.class).build(settings);
5150
}
5251

53-
@Override
54-
public String getName(UUID uuid) {
55-
return plugin.get(NameProviderManager.class).getName(uuid);
56-
}
57-
5852
@Override
5953
public Agent createTaskAgent(Runnable runnable, boolean async, long delay) {
6054
return new SpigotRunnableAgent(runnable, async ? AsyncScheduler.get(plugin) : GlobalScheduler.get(plugin), delay);

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
<properties>
4949
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
5050
<minelib.version>1.2.5</minelib.version>
51-
<topper.version>4.10.0</topper.version>
51+
<topper.version>4.11.0</topper.version>
5252
<core.version>4.6.0</core.version>
5353
<java.version>1.8</java.version>
5454
</properties>

0 commit comments

Comments
 (0)