Merge pull request #7 from gionnivaleriana/patch-1

getTasksByFilter ignores filters beside the predefined ones

Author: Torann

src/Torann/LaravelAsana/Asana.php

@@ -242,13 +242,11 @@ public function removeProjectToTask($taskId, $projectId = null)
      */
     public function getTasksByFilter($filter = ["assignee" => "", "project" => "", "workspace" => ""])
     {
-        $url = "";
-        $filter = array_merge(["assignee" => "", "project" => "", "workspace" => ""], $filter);
-        $url .= $filter["assignee"] != "" ? "&assignee={$filter["assignee"]}" : "";
-        $url .= $filter["project"] != "" ? "&project={$filter["project"]}" : "";
-        $url .= $filter["workspace"] != "" ? "&workspace={$filter["workspace"]}" : "";
-        if (strlen($url) > 0) $url = "?" . substr($url, 1);
-
+        $filter = array_filter(array_merge(["assignee" => "", "project" => "", "workspace" => ""], $filter));
+        $url = '?' . join('&', array_map(function($k, $v){
+            return "{$k}={$v}";
+        }, array_keys($filter), $filter));
+        
         return $this->curl->get("tasks{$url}");
     }