Skip to content

Commit 026f313

Browse files
TortoiseWolfeclaude
andcommitted
feat: add ScriptHammer.com link to footer, document manifest issue
- Footer now links to ScriptHammer.com for template reference - Added Issue #12 to FORKING-FEEDBACK.md documenting that manifest.json is generated and requires updating scripts/generate-manifest.js rather than the manifest file directly 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 8dd1e36 commit 026f313

File tree

2 files changed

+71
-2
lines changed

2 files changed

+71
-2
lines changed

FORKING-FEEDBACK.md

Lines changed: 62 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ This document captures issues encountered when forking the ScriptHammer template
44

55
## Summary
66

7-
Forking ScriptHammer required updating **200+ files** with hardcoded references. The Docker-first architecture also created friction with git hooks. Additionally, tests require Supabase mocking, description assertions need updating, **the basePath secret in deploy.yml breaks GitHub Pages for forks** (Issue #10), and **production crashes without Supabase GitHub secrets** (Issue #11).
7+
Forking ScriptHammer required updating **200+ files** with hardcoded references. The Docker-first architecture also created friction with git hooks. Additionally, tests require Supabase mocking, description assertions need updating, **the basePath secret in deploy.yml breaks GitHub Pages for forks** (Issue #10), **production crashes without Supabase GitHub secrets** (Issue #11), **the footer template link needs manual update** (Issue #12), and **the PWA manifest description is generated at build time** (Issue #13).
88

99
---
1010

@@ -320,6 +320,67 @@ Error: Missing Supabase environment variables. Please set NEXT_PUBLIC_SUPABASE_U
320320
- Document Supabase setup as a required step in the fork workflow
321321
- Or modify `src/lib/supabase/client.ts` to return a disabled mock client instead of throwing, allowing the app to run in "offline mode" without Supabase
322322

323+
### 12. Footer Template Link Needs Manual Update
324+
325+
**Problem:** The footer says "Open source template available" but doesn't link anywhere. Forkers need to manually add a link back to the template source.
326+
327+
**Current Code** (`src/components/Footer.tsx`):
328+
329+
```tsx
330+
<p className="text-base-content/40 mt-1 text-xs">
331+
Open source template available
332+
</p>
333+
```
334+
335+
**Suggested Fix:** The template should include the link by default:
336+
337+
```tsx
338+
<p className="text-base-content/40 mt-1 text-xs">
339+
Open source template available at{' '}
340+
<a
341+
href="https://scripthammer.com"
342+
target="_blank"
343+
rel="noopener noreferrer"
344+
className="link-hover link"
345+
>
346+
ScriptHammer.com
347+
</a>
348+
</p>
349+
```
350+
351+
### 13. PWA Manifest Description is Generated, Not Static
352+
353+
**Problem:** After rebranding, the `public/manifest.json` keeps reverting to the old template description even after editing it directly.
354+
355+
**Root Cause:** `public/manifest.json` is **generated** by `scripts/generate-manifest.js` during the prebuild process. Line 53 has a hardcoded description:
356+
357+
```javascript
358+
description: `${projectConfig.projectName} - Modern Next.js template with PWA, theming, and interactive components`,
359+
```
360+
361+
**Files that need description updates for rebranding:**
362+
363+
| File | Purpose |
364+
| ---------------------------------------- | ------------------------------------- |
365+
| `scripts/generate-manifest.js` (line 53) | **Source** - PWA manifest description |
366+
| `src/app/page.tsx` (lines 66-74) | Home page hero tagline |
367+
| `package.json` | npm package description |
368+
| `src/config/project.config.ts` | App description constant |
369+
| `README.md` | Repository description |
370+
371+
**Suggested Fix:**
372+
373+
1. Add `public/manifest.json` to `.gitignore` (it's generated)
374+
2. Update the description in `scripts/generate-manifest.js` not the manifest file
375+
3. Document this in the rebrand script or README
376+
377+
**Verification:**
378+
379+
```bash
380+
docker compose exec spoketowork node scripts/generate-manifest.js
381+
cat public/manifest.json | grep description
382+
```
383+
323384
---
324385

325386
## Recommended Fork Workflow

src/components/Footer.tsx

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,15 @@ export function Footer() {
2525
</a>
2626
</p>
2727
<p className="text-base-content/40 mt-1 text-xs">
28-
Open source template available
28+
Open source template available at{' '}
29+
<a
30+
href="https://scripthammer.com"
31+
target="_blank"
32+
rel="noopener noreferrer"
33+
className="link-hover link"
34+
>
35+
ScriptHammer.com
36+
</a>
2937
</p>
3038
</div>
3139
</footer>

0 commit comments

Comments
 (0)