Skip to content

Commit 8d6bf4b

Browse files
committed
Remove forced warning flags from INTERFACE target based on feedback from david-fong
1 parent 66f9ef6 commit 8d6bf4b

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

CMakeLists.txt

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,7 @@ target_include_directories(pcg-cpp INTERFACE
1515

1616
target_compile_features(pcg-cpp INTERFACE cxx_std_11)
1717

18-
if(MSVC)
19-
target_compile_options(pcg-cpp INTERFACE /W4 /FS) # /FS fixes C1090 PDB race conditions
20-
else()
21-
target_compile_options(pcg-cpp INTERFACE -Wall -Wextra -Wpedantic)
22-
endif()
18+
2319

2420
# Options
2521
option(PCG_CPP_BUILD_SAMPLES "Build samples" ON)

CREDITS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,4 +49,4 @@ This modernized fork of `pcg-cpp` by **Total-Random** integrates several critica
4949
- `C4127` (conditional expression is constant) in template code.
5050

5151
## Special Thanks
52-
Special thanks to **Melissa O'Neill** for creating the original PCG library and to all the community members who have proposed fixes over the years.
52+
Special thanks to **Melissa O'Neill** for creating the original PCG library and to all the community members who have proposed fixes over the years, including **david-fong** for valuable build system feedback.

0 commit comments

Comments
 (0)