Merge pull request #148 from TotallyNotRobots/horoscope-cov

Add missing coverage for horoscope.py

Author: linuxdaemon

tests/plugin_tests/test_horoscope.py

@@ -3,15 +3,15 @@
 import pytest
 import requests
 
+from plugins import horoscope
+
 URL = (
     "http://www.horoscope.com/us/horoscopes/general/"
     "horoscope-general-daily-today.aspx?sign={sign}"
 )
 
 
 def setup_db(mock_db):
-    from plugins import horoscope
-
     horoscope.table.create(mock_db.engine, checkfirst=True)
     sess = mock_db.session()
     sess.execute(horoscope.table.delete())
@@ -20,13 +20,11 @@ def setup_db(mock_db):
 
 
 def test_horoscope(mock_requests, mock_db):
-    from plugins import horoscope
-
     sess = setup_db(mock_db)
     mock_requests.add(
-        'GET',
+        "GET",
         URL.format(sign=1),
-        headers={'User-Agent': "Some user agent"},
+        headers={"User-Agent": "Some user agent"},
         body="""
         <div class="main-horoscope">
             <p>Some horoscope text</p>
@@ -39,40 +37,36 @@ def test_horoscope(mock_requests, mock_db):
     bot = MagicMock()
     bot.user_agent = "Some user agent"
 
-    response = horoscope.horoscope("aries", sess, bot, 'some_user', event)
+    response = horoscope.horoscope("aries", sess, bot, "some_user", event)
 
     assert response is None
 
     event.message.assert_called_once_with("\x02aries\x02 Some horoscope text")
 
-    assert mock_db.get_data(horoscope.table) == [('some_user', 'aries')]
+    assert mock_db.get_data(horoscope.table) == [("some_user", "aries")]
 
 
 def test_invalid_syntax(mock_requests, mock_db):
-    from plugins import horoscope
-
     sess = setup_db(mock_db)
 
     event = MagicMock()
     bot = MagicMock()
     bot.user_agent = "Some user agent"
 
-    response = horoscope.horoscope('', sess, bot, 'some_user', event)
+    response = horoscope.horoscope("", sess, bot, "some_user", event)
 
     assert response is None
 
     assert event.notice_doc.call_count == 1
 
 
 def test_database_read(mock_requests, mock_db):
-    from plugins import horoscope
-
     sess = setup_db(mock_db)
 
     mock_requests.add(
-        'GET',
+        "GET",
         URL.format(sign=4),
-        headers={'User-Agent': "Some user agent"},
+        headers={"User-Agent": "Some user agent"},
         body="""
         <div class="main-horoscope">
             <p>Some horoscope text</p>
@@ -81,28 +75,26 @@ def test_database_read(mock_requests, mock_db):
         match_querystring=True,
     )
 
-    mock_db.add_row(horoscope.table, nick='some_user', sign='cancer')
+    mock_db.add_row(horoscope.table, nick="some_user", sign="cancer")
 
     event = MagicMock()
     bot = MagicMock()
     bot.user_agent = "Some user agent"
 
-    response = horoscope.horoscope('', sess, bot, 'some_user', event)
+    response = horoscope.horoscope("", sess, bot, "some_user", event)
 
     assert response is None
 
     event.message.assert_called_once_with("\x02cancer\x02 Some horoscope text")
 
 
 def test_parse_fail(mock_requests, mock_db):
-    from plugins import horoscope
-
     sess = setup_db(mock_db)
 
     mock_requests.add(
-        'GET',
+        "GET",
         URL.format(sign=4),
-        headers={'User-Agent': "Some user agent"},
+        headers={"User-Agent": "Some user agent"},
         body="""
         <div class="main-horoscope">
         </div>
@@ -115,25 +107,35 @@ def test_parse_fail(mock_requests, mock_db):
     bot.user_agent = "Some user agent"
 
     with pytest.raises(horoscope.HoroscopeParseError):
-        horoscope.horoscope('cancer', sess, bot, 'some_user', event)
+        horoscope.horoscope("cancer", sess, bot, "some_user", event)
 
     event.reply.assert_called_once_with("Unable to parse horoscope posting")
 
 
 def test_page_error(mock_requests, mock_db):
-    from plugins import horoscope
-
     sess = setup_db(mock_db)
 
     event = MagicMock()
     bot = MagicMock()
     bot.user_agent = "Some user agent"
 
-    mock_requests.add('GET', URL.format(sign=1), status=404)
+    mock_requests.add("GET", URL.format(sign=1), status=404)
 
     with pytest.raises(requests.RequestException):
-        horoscope.horoscope('aries', sess, bot, 'some_user', event)
+        horoscope.horoscope("aries", sess, bot, "some_user", event)
 
     event.reply.assert_called_once_with(
-        "Could not get horoscope: 404 Client Error: Not Found for url: {}. URL Error".format(URL.format(sign=1))
+        "Could not get horoscope: 404 Client Error: Not Found for url: {}. URL Error".format(
+            URL.format(sign=1)
+        )
     )
+
+
+def test_bad_sign(mock_requests):
+    db = MagicMock()
+    event = MagicMock()
+    sign = "some_sign"
+    res, err = horoscope.parse_or_lookup(sign, db, "foobar", event)
+    assert res is None
+    assert err is None
+    event.notice.assert_called_with("Unknown sign: {}".format(sign))