Make event queueing non-async

Make sure all events are queued before handling the next line

Author: linuxdaemon

CHANGELOG.md

@@ -17,6 +17,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Handle 'a' vs 'an' in drinks plugin
 - Apply rate limiting to regex hooks
 - Ensure event order is deterministic
+- Make event queueing happen non-async
 ### Fixed
 - Ensure event order is deterministic
 - Fix matching exception in horoscope test

cloudbot/bot.py

@@ -296,7 +296,7 @@ def load_clients(self):
         scanner = Scanner(bot=self)
         scanner.scan(clients, categories=['cloudbot.client'])
 
-    async def process(self, event):
+    def process(self, event):
         """
         :type event: Event
         """
@@ -397,8 +397,5 @@ def add_hook(hook, _event):
 
         tasks.sort(key=lambda t: t[0].priority)
 
-        # Run the tasks
-        await asyncio.gather(*[
-            asyncio.ensure_future(self.plugin_manager.launch(hook, _event))
-            for hook, _event in tasks
-        ], loop=self.loop)
+        for _hook, _event in tasks:
+            async_util.wrap_future(self.plugin_manager.launch(_hook, _event))

cloudbot/clients/irc.py

@@ -464,8 +464,8 @@ def data_received(self, data):
                     self.conn.name, line, self.conn.describe_server()
                 )
             else:
-                # handle the message, async
-                async_util.wrap_future(self.bot.process(event), loop=self.loop)
+                # handle the message
+                self.bot.process(event)
 
     def parse_line(self, line: str) -> Event:
         message = Message.parse(line)