Properly handle empty log_channel

Author: linuxdaemon

plugins/core/core_misc.py

@@ -111,12 +111,12 @@ async def onjoin(conn, bot):
         conn.cmd("MODE", conn.nick, mode)
 
     log_chan = conn.config.get("log_channel")
-    if " " in log_chan:
-        log_chan, key = log_chan.split(None, 1)
-    else:
-        key = None
-
     if log_chan:
+        if " " in log_chan:
+            log_chan, key = log_chan.split(None, 1)
+        else:
+            key = None
+
         conn.join(log_chan, key)
 
     conn.ready = True

tests/plugin_tests/core_misc_test.py

@@ -1,5 +1,6 @@
-from unittest.mock import call
+from unittest.mock import MagicMock, call
 
+import pytest
 from irclib.parser import ParamList
 
 from plugins.core import core_misc
@@ -28,3 +29,26 @@ def test_invite_join_disabled():
     core_misc.invite(ParamList("foo", "#bar"), conn)
 
     assert conn.send.mock_calls == []
+
+
+@pytest.mark.asyncio()
+@pytest.mark.parametrize(
+    "config,calls",
+    [
+        ({}, []),
+        ({"log_channel": "#foo"}, [call("JOIN #foo")]),
+        ({"log_channel": "#foo bar"}, [call("JOIN #foo bar")]),
+        ({"log_channel": "#foo bar baz"}, [call("JOIN #foo :bar baz")]),
+    ],
+)
+async def test_on_connect(config, calls):
+    bot = MagicMock()
+    config = config.copy()
+    config.setdefault("connection", {}).setdefault("server", "host.invalid")
+    conn = MockIrcClient(bot, "fooconn", "foobot", config)
+
+    res = await core_misc.onjoin(conn, bot)
+
+    assert res is None
+
+    assert conn.send.mock_calls == calls