Add mypy and pylint workflows

Author: linuxdaemon

.github/workflows/mypy.yml

@@ -0,0 +1,31 @@
+name: Mypy type checking
+on:
+  push:
+    branches:
+    - main
+  pull_request:
+    branches:
+    - main
+jobs:
+  check:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/[email protected]
+      with:
+        fetch-depth: 0
+    - name: Set up Python 3.8
+      uses: actions/[email protected]
+      with:
+        python-version: 3.8
+    - uses: actions/[email protected]
+      with:
+        path: ~/.cache/pip
+        key: ${{ runner.os }}-pip-${{ hashFiles('**/requirements*.txt') }}
+        restore-keys: |
+          ${{ runner.os }}-pip-
+    - name: Install apt deps
+      run: sudo apt-get update && sudo apt-get install -qq -y libenchant-dev libxml2-dev libxslt1-dev
+    - name: Install dependencies
+      run: pip install -Ur requirements-dev.txt
+    - name: Test with mypy
+      run: pre-commit run mypy --all

.github/workflows/pylint.yml

@@ -0,0 +1,31 @@
+name: Pylint analysis
+on:
+  push:
+    branches:
+    - main
+  pull_request:
+    branches:
+    - main
+jobs:
+  check:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/[email protected]
+      with:
+        fetch-depth: 0
+    - name: Set up Python 3.8
+      uses: actions/[email protected]
+      with:
+        python-version: 3.8
+    - uses: actions/[email protected]
+      with:
+        path: ~/.cache/pip
+        key: ${{ runner.os }}-pip-${{ hashFiles('**/requirements*.txt') }}
+        restore-keys: |
+          ${{ runner.os }}-pip-
+    - name: Install apt deps
+      run: sudo apt-get update && sudo apt-get install -qq -y libenchant-dev libxml2-dev libxslt1-dev
+    - name: Install dependencies
+      run: pip install -Ur requirements-dev.txt
+    - name: Run pylint
+      run: pre-commit run pylint --all

.mypy.ini

@@ -7,3 +7,6 @@ strict_optional = False
 ignore_missing_imports = True
 check_untyped_defs = True
 show_error_codes = True
+warn_unused_ignores = True
+warn_redundant_casts = True
+;strict_equality = True

plugins/profiling.py

@@ -1,4 +1,3 @@
-import os
 import signal
 import sys
 import threading
@@ -123,12 +122,17 @@ def pympler_diff():
     return "Printed to console"
 
 
+try:
+    SIGUSR1 = getattr(signal, "SIGUSR1")
+except AttributeError:
+    SIGUSR1 = None
+
 # # Provide an easy way to get a threaddump, by using SIGUSR1 (only on POSIX systems)
-if os.name == "posix":
+if SIGUSR1 is not None:
     # The handler is called with two arguments: the signal number and the current stack frame
     # These parameters should NOT be removed
     # noinspection PyUnusedLocal
     def debug(sig, frame):
         print(get_thread_dump())
 
-    signal.signal(signal.SIGUSR1, debug)  # Register handler
+    signal.signal(SIGUSR1, debug)  # Register handler

plugins/tvdb.py

@@ -209,7 +209,7 @@ class Holder(Generic[T]):
     """
 
     def __init__(self) -> None:
-        self._item = None  # type: Optional[T]
+        self._item: Optional[T] = None
         self._set = False
 
     def set(self, item: T) -> None:
@@ -245,7 +245,7 @@ def get(self) -> T:
         if not self._set:
             raise MissingItem()
 
-        return cast(T, self._item)
+        return self._item
 
 
 class LazyCollection(Sized, Iterable[T], Container[T]):

requirements-dev.txt

@@ -1,6 +1,7 @@
 coverage == 6.0.1
 freezegun == 1.1.0
 mypy == 0.910
+pre-commit == 2.15.0
 pylint == 2.11.1
 pytest == 6.2.5
 pytest-asyncio == 0.15.1