Skip to content

Commit d111347

Browse files
committed
Merge branch 'main' into engineioxide-client
2 parents c27e3b1 + f05cb2c commit d111347

File tree

6 files changed

+6
-29
lines changed

6 files changed

+6
-29
lines changed

Cargo.lock

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

crates/engineioxide-core/src/packet.rs

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -208,20 +208,7 @@ impl From<Packet> for String {
208208
buffer
209209
}
210210
}
211-
<<<<<<< HEAD:crates/engineioxide-core/src/packet.rs
212211

213-
=======
214-
impl From<Packet> for tokio_tungstenite::tungstenite::Utf8Bytes {
215-
fn from(value: Packet) -> Self {
216-
String::from(value).into()
217-
}
218-
}
219-
impl From<Packet> for Bytes {
220-
fn from(value: Packet) -> Self {
221-
String::from(value).into()
222-
}
223-
}
224-
>>>>>>> origin/main:crates/engineioxide/src/packet.rs
225212
/// Deserialize a [Packet] from a [String] according to the Engine.IO protocol
226213
impl TryFrom<Str> for Packet {
227214
type Error = PacketParseError;

crates/engineioxide-core/src/payload/encoder.rs

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -114,11 +114,7 @@ pub async fn v4_encoder(
114114
/// [engine.io v3 protocol](https://github.com/socketio/engine.io-protocol/tree/v3#payload)
115115
#[cfg(feature = "v3")]
116116
pub fn v3_bin_packet_encoder(packet: Packet, data: &mut bytes::BytesMut) {
117-
<<<<<<< HEAD:crates/engineioxide-core/src/payload/encoder.rs
118117
use crate::payload::BINARY_PACKET_SEPARATOR_V3;
119-
=======
120-
use crate::transport::polling::payload::BINARY_PACKET_SEPARATOR_V3;
121-
>>>>>>> origin/main:crates/engineioxide/src/transport/polling/payload/encoder.rs
122118
use bytes::BufMut;
123119

124120
let mut itoa = itoa::Buffer::new();
@@ -158,11 +154,7 @@ pub fn v3_bin_packet_encoder(packet: Packet, data: &mut bytes::BytesMut) {
158154
/// [engine.io v3 protocol](https://github.com/socketio/engine.io-protocol/tree/v3#payload)
159155
#[cfg(feature = "v3")]
160156
pub fn v3_string_packet_encoder(packet: Packet, data: &mut bytes::BytesMut) {
161-
<<<<<<< HEAD:crates/engineioxide-core/src/payload/encoder.rs
162157
use crate::payload::STRING_PACKET_SEPARATOR_V3;
163-
=======
164-
use crate::transport::polling::payload::STRING_PACKET_SEPARATOR_V3;
165-
>>>>>>> origin/main:crates/engineioxide/src/transport/polling/payload/encoder.rs
166158
use bytes::BufMut;
167159
let packet: String = packet.into();
168160
let packet = format!(

crates/engineioxide/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
# engineioxide 0.17.1
2+
* fix: upgrade process was timing out when the client made accidentally more
3+
than one polling requests while upgrading (#497).
4+
15
# engineioxide 0.17
26
* MSRV: rust-version is now 1.86 with edition 2024
37

crates/engineioxide/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
[package]
22
name = "engineioxide"
33
description = "Engine IO server implementation in rust as a Tower Service."
4-
version = "0.17.0"
4+
version = "0.17.1"
55
edition.workspace = true
66
rust-version.workspace = true
77
authors.workspace = true

crates/engineioxide/src/transport/ws.rs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -334,14 +334,8 @@ where
334334
};
335335
match Packet::try_from(ws_bytes_to_str(msg))? {
336336
Packet::PingUpgrade => {
337-
<<<<<<< HEAD
338-
socket.start_upgrade();
339-
let pong: String = Packet::PongUpgrade.into();
340-
=======
341337
#[cfg(feature = "tracing")]
342338
tracing::debug!("received first ping upgrade");
343-
344-
>>>>>>> origin/main
345339
// Respond with a PongUpgrade packet
346340
ws.send(Message::Text(pong.into())).await?;
347341
}

0 commit comments

Comments
 (0)