Skip to content

Commit ff54dd5

Browse files
committed
build: fix windows builds
1 parent ddf156e commit ff54dd5

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

binding.gyp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,20 +66,22 @@
6666
"library_dirs": [
6767
"<!@(pkg-config oopetris-recordings --libs-only-L | sed s/-L//g)",
6868
],
69-
"msvs_settings": { ## settinsg cflags_cc doesn't really work onw windows, so using this
69+
"msvs_settings": { # setting cflags_cc doesn't really work onw windows, so using this
7070
"VCCLCompilerTool": {
7171
"AdditionalOptions": [
7272
"/std:c++latest",
7373
"/W4",
7474
"/EHsc",
7575
"/O2",
76+
"/utf-8", # since fmt.h has some warnings without that
7677
"/wd4100", # since nan.h -> node.h has some warnings regarding that
7778
"<!@(pkg-config oopetris-recordings --cflags)",
7879
]
7980
},
8081
"VCLinkerTool": {
8182
"AdditionalDependencies": [
82-
"<!@(pkg-config oopetris-recordings --libs-only-l | sed s/-l/lib/g |sed 's/\\s/.a /g')", # adjust to the default setting, namely lib<name>.a via some sed magic
83+
# adjust to the default setting, namely lib<name>.a via some sed magic
84+
"<!@(pkg-config oopetris-recordings --libs-only-l | sed s/-l/lib/g |sed 's/\\s/.a /g')",
8385
],
8486
},
8587
},

0 commit comments

Comments
 (0)