chore: make both mypy and pyright happy (#370)

Author: PrettyWood

python/fastexcel/__init__.py

@@ -18,11 +18,11 @@
 from pathlib import Path
 
 try:
-    import pyarrow as pa
+    import importlib.util
 
+    importlib.util.find_spec("pyarrow")
     _PYARROW_AVAILABLE = True
 except ImportError:
-    pa = None
     _PYARROW_AVAILABLE = False
 
 from ._fastexcel import (
@@ -458,21 +458,34 @@ def load_table(
         :param dtypes: An optional dtype (for all columns)
                        or dict of dtypes with keys as column indices or names.
         """
-        output = self._reader.load_table(  # type:ignore[call-overload,misc]
-            name=name,
-            header_row=header_row,
-            column_names=column_names,
-            skip_rows=skip_rows,
-            n_rows=n_rows,
-            schema_sample_rows=schema_sample_rows,
-            dtype_coercion=dtype_coercion,
-            use_columns=use_columns,
-            dtypes=dtypes,
-            eager=eager,
-        )
         if eager:
-            return output
-        return ExcelTable(output)
+            return self._reader.load_table(
+                name=name,
+                header_row=header_row,
+                column_names=column_names,
+                skip_rows=skip_rows,
+                n_rows=n_rows,
+                schema_sample_rows=schema_sample_rows,
+                dtype_coercion=dtype_coercion,
+                use_columns=use_columns,
+                dtypes=dtypes,
+                eager=True,
+            )
+        else:
+            return ExcelTable(
+                self._reader.load_table(
+                    name=name,
+                    header_row=header_row,
+                    column_names=column_names,
+                    skip_rows=skip_rows,
+                    n_rows=n_rows,
+                    schema_sample_rows=schema_sample_rows,
+                    dtype_coercion=dtype_coercion,
+                    use_columns=use_columns,
+                    dtypes=dtypes,
+                    eager=False,
+                )
+            )
 
     def load_sheet_eager(
         self,

python/tests/benchmarks/memory.py

@@ -1,7 +1,7 @@
 import argparse
 from enum import Enum
 
-from readers import fastexcel_read, pyxl_read, xlrd_read
+from .readers import fastexcel_read, pyxl_read, xlrd_read
 
 
 class Engine(str, Enum):

python/tests/benchmarks/readers.py

@@ -9,16 +9,16 @@ def pyxl_read(test_file_path: str):
         rows = ws.iter_rows()
         rows = ws.values
         for row in rows:
-            for value in row:
-                value
+            for _ in row:
+                pass
 
 
 def xlrd_read(test_file_path: str):
     wb = open_workbook(test_file_path)
     for ws in wb.sheets():
         for idx in range(ws.nrows):
-            for value in ws.row_values(idx):
-                value
+            for _ in ws.row_values(idx):
+                pass
 
 
 def fastexcel_read(test_file_path: str):

python/tests/benchmarks/speed.py

@@ -3,7 +3,8 @@
 """
 
 import pytest
-from readers import fastexcel_read, pyxl_read, xlrd_read
+
+from .readers import fastexcel_read, pyxl_read, xlrd_read
 
 
 @pytest.fixture