Skip to content

Commit 377a951

Browse files
authored
build: Specify all maturin features in pyproject.toml (#379)
1 parent dc04c3f commit 377a951

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

.github/workflows/CI.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ jobs:
105105
with:
106106
manylinux: auto
107107
command: build
108-
args: "-o dist --features __maturin"
108+
args: "-o dist"
109109
target: ${{ steps.target.outputs.target }}
110110

111111
- name: Upload wheels

.github/workflows/release.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
with:
2222
manylinux: auto
2323
command: build
24-
args: "--release -o dist --features __maturin"
24+
args: "--release -o dist"
2525
target: ${{ matrix.architecture == 'aarch64' && 'aarch64-unknown-linux-gnu' || null }}
2626
- name: Upload wheels
2727
uses: actions/upload-artifact@v4
@@ -42,7 +42,7 @@ jobs:
4242
uses: PyO3/maturin-action@v1
4343
with:
4444
command: build
45-
args: "--release -o dist --features __maturin"
45+
args: "--release -o dist"
4646
target: ${{ matrix.architecture == 'aarch64' && 'aarch64-apple-darwin' || 'x86_64-apple-darwin' }}
4747
- name: Upload wheels
4848
uses: actions/upload-artifact@v4
@@ -63,7 +63,7 @@ jobs:
6363
uses: PyO3/maturin-action@v1
6464
with:
6565
command: build
66-
args: "--release -o dist --features __maturin"
66+
args: "--release -o dist"
6767
- name: Upload wheels
6868
uses: actions/upload-artifact@v4
6969
with:

Makefile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,12 @@ export CARGO_TERM_COLOR=$(shell (test -t 0 && echo "always") || echo "auto")
1010
.PHONY: install ## Install the package & dependencies with debug build
1111
install: .uv
1212
uv sync --frozen --group all
13-
uv run maturin develop --features __maturin --uv -E pandas,polars
13+
uv run maturin develop --uv -E pandas,polars
1414

1515
.PHONY: install-prod ## Install the package & dependencies with release build
1616
install-prod: .uv
1717
uv sync --frozen --group all
18-
uv run maturin develop --features __maturin --uv --release -E pandas,polars
18+
uv run maturin develop --uv --release -E pandas,polars
1919

2020
.PHONY: setup-dev ## First-time setup: install + pre-commit hooks
2121
setup-dev: install
@@ -28,12 +28,12 @@ rebuild-lockfiles: .uv
2828

2929
.PHONY: build-dev ## Build the development version of the package
3030
build-dev:
31-
uv run maturin build --features __maturin
31+
uv run maturin build
3232

3333
.PHONY: build-wheel ## Build production wheel and install it
3434
build-wheel:
3535
@rm -rf target/wheels/
36-
uv run maturin build --release --features __maturin
36+
uv run maturin build --release
3737
@wheel=$$(ls target/wheels/*.whl); uv pip install --force-reinstall "$$wheel[pandas,polars]"
3838

3939
.PHONY: lint-python ## Lint python source files

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ Issues = "https://github.com/ToucanToco/fastexcel"
6464
[tool.maturin]
6565
python-source = "python"
6666
module-name = "fastexcel._fastexcel"
67-
features = ["pyo3/extension-module"]
67+
features = ["__maturin"]
6868

6969
[tool.mypy]
7070
python_version = "3.9"

0 commit comments

Comments
 (0)