Fix typos and update config files

Author: Avasam

mypy.ini

@@ -1,25 +1,45 @@
-; We don't run mypy in the CI. This is just to help anyone who would like to use it manually.
-; Namely, the mypy_primer tool.
+# SPDX-License-Identifier: MIT
+# Copyright 2024 Beslogic Inc.
+
+# The source skeleton for this configuration can be found at
+# https://github.com/BesLogic/shared-configs/blob/main/mypy.ini
+# Modifications to this file that are not project-specific should also be done upstream.
+
+# https://mypy.readthedocs.io/en/stable/config_file.html
 [mypy]
-python_version = 3.11
+###
+# General settings
+###
 show_column_numbers = true
-mypy_path = $MYPY_CONFIG_FILE_DIR/typings
-implicit_reexport = true
-
 strict = true
-; Implicit return types !
+report_deprecated_as_note = true
+
+# All below are rules and codes not enabled by default even with strict=true
+; <removed section from upstream>
+; We don't run mypy in the CI. This is just to help anyone who would like to use it manually.
+; Namely, the mypy_primer tool.
+
+# Implicit return types using pyright ! (mypy doesn't do implicit return types)
+# Note: mypy still has issues with some boolean inferred returns:
+# https://github.com/python/mypy/issues/4409
+# https://github.com/python/mypy/issues/10149
+# Comment out if not using pyright or implicit types
 check_untyped_defs = true
 disallow_untyped_calls = false
 disallow_untyped_defs = false
 disallow_incomplete_defs = false
-disable_error_code = return
-# Note: mypy still has issues with some boolean infered returns like `is_valid_hwnd`
-# https://github.com/python/mypy/issues/4409
-# https://github.com/python/mypy/issues/10149
+
+###
+# Specific to this project
+###
 
 ; exclude mypyc build
 exclude = .*(build)/.*
 
+python_version = 3.11
+mypy_path = $MYPY_CONFIG_FILE_DIR/typings
+implicit_reexport = true
+
 ; Auto-generated code, not much we can do there
 [mypy-gen.*]
 disable_error_code = attr-defined, arg-type

ruff.toml

@@ -8,7 +8,7 @@
 # https://docs.astral.sh/ruff/configuration/
 line-length = 100
 preview = true
-required-version = ">=0.11.0" # tool.ruff.target-version is infered from project.requires-python
+required-version = ">=0.11.0" # tool.ruff.target-version is inferred from project.requires-python
 
 [format]
 docstring-code-format = true
@@ -20,7 +20,7 @@ ignore = [
   ###
   # Not needed or wanted
   ###
-  "D1", # pydocstyle Missing doctring
+  "D1", # pydocstyle Missing docstring
   "D401", # pydocstyle: non-imperative-mood
   "EM", # flake8-errmsg
   # This is often something we can't control: https://github.com/astral-sh/ruff/issues/9497
@@ -47,6 +47,15 @@ ignore = [
   "D212", # pydocstyle: multi-line-summary-first-line
   # Allow differentiating between broken (FIXME) and to be done/added/completed (TODO)
   "TD001", # flake8-todos: invalid-todo-tag
+  # Often just leads to redundant more verbose code when needing an actual str
+  "PTH208", # Use `pathlib.Path.iterdir()` instead.
+  # Typeshed doesn't want complex or non-literal defaults for maintenance and testing reasons.
+  # This doesn't affect us, let's have more complete stubs.
+  # This doesn't affect us, let's have more complete stubs.
+  "PYI011", # typed-argument-default-in-stub
+  "PYI011", # typed-argument-default-in-stub
+  "PYI014", # argument-default-in-stub
+  "PYI053", # string-or-bytes-too-long
 
   ###
   # These should be warnings (https://github.com/astral-sh/ruff/issues/1256 & https://github.com/astral-sh/ruff/issues/1774)
@@ -57,6 +66,8 @@ ignore = [
 
   # False-positives
   "TC004", # https://github.com/astral-sh/ruff/issues/3821
+  # Too many magic number "2" that are preferable inline. https://github.com/astral-sh/ruff/issues/10009
+  "PLR2004", # magic-value-comparison
 
   ###
   # Conflict with formatter (you can remove this section if you don't use Ruff as a formatter)
@@ -107,8 +118,6 @@ allow-multiline = false
 [lint.isort]
 combine-as-imports = true
 split-on-trailing-comma = false
-# This should be automatically detected in src layout, but somehow pre-commit messes it up
-known-first-party = ["gen"]
 
 # https://docs.astral.sh/ruff/settings/#mccabe
 [lint.mccabe]
@@ -149,8 +158,8 @@ max-branches = 15
 "cv2.imread".msg = """\
 it doesn't support special characters. \
 Use `cv2.imdecode(np.fromfile(filename, dtype=np.uint8), flags)` instead.
-https://github.com/opencv/opencv/issues/4292#issuecomment-2266019697"""
+https://github.com/opencv/opencv/issues/18305#issuecomment-2847972863"""
 "cv2.imwrite".msg = """\
 it doesn't support special characters. \
 Use `cv2.imencode(os.path.splitext(filename)[1], img)[1].tofile(filename)` instead.
-https://github.com/opencv/opencv/issues/4292#issuecomment-2266019697"""
+https://github.com/opencv/opencv/issues/18305#issuecomment-2847972863"""

src/user_profile.py

@@ -228,7 +228,7 @@ def load_check_for_updates_on_open(autosplit: "AutoSplit"):
     Retrieve the "Check For Updates On Open" QSettings and set the checkbox state
     These are only global settings values. They are not *toml settings values.
     """
-    # Type not infered by PySide6: https://bugreports.qt.io/browse/PYSIDE-2542
+    # Type not inferred by PySide6: https://bugreports.qt.io/browse/PYSIDE-2542
     value = cast(
         bool,
         QtCore.QSettings(