Fix OCR validation

Author: Avasam

ruff.toml

@@ -4,12 +4,12 @@
 # The source skeleton for this configuration can be found at
 # https://github.com/BesLogic/shared-configs/blob/main/ruff.toml
 # Modifications to this file that are not project-specific should also be done upstream.
-# These configs are incompatible with ruff<0.5.7
 
 # https://docs.astral.sh/ruff/configuration/
 target-version = "py311" # Change this to the oldest supported version by your application
 line-length = 100
 preview = true
+required-version = ">=0.9.0" # Removed ISC compatibility warning
 
 [format]
 docstring-code-format = true

src/AutoSplitImage.py

@@ -135,22 +135,26 @@ def __parse_text_file(self, path: str):
 
         with open(path, mode="rb") as f:
             data = tomllib.load(f)
+        try:
+            self.texts = [text.lower().strip() for text in data["texts"]]
+            self.__rect = (data["left"], data["right"], data["top"], data["bottom"])
+        except KeyError as exception:
+            error_messages.ocr_missing_key(path, exception.args[0])
+            return
 
-        self.texts = [text.lower().strip() for text in data["texts"]]
-        self.__rect = (data["left"], data["right"], data["top"], data["bottom"])
         self.__ocr_comparison_methods = data.get("methods", [0])
         self.__fps_limit = data.get("fps_limit", 0)
 
-        if self.__validate_ocr():
+        if not self.__validate_ocr():
             error_messages.wrong_ocr_values(path)
             return
 
     def __validate_ocr(self):
         values = [*self.__rect, *self.__ocr_comparison_methods, self.__fps_limit]
         return (
             all(value >= 0 for value in values)  # Check for invalid negative values
-            and self.__rect[1] > self.__rect[0]
-            and self.__rect[3] > self.__rect[2]
+            and self.__rect[0] < self.__rect[1]
+            and self.__rect[2] < self.__rect[3]
         )
 
     def __read_image_bytes(self, path: str):

src/error_messages.py

@@ -267,9 +267,13 @@ def tesseract_missing(ocr_split_file_path: str):
     )
 
 
+def ocr_missing_key(ocr_split_file_path: str, missing_key: str):
+    set_text_message(f"{ocr_split_file_path!r} is missing an entry for {missing_key!r}")
+
+
 def wrong_ocr_values(ocr_split_file_path: str):
     set_text_message(
         f"{ocr_split_file_path!r} has invalid values."
-        + "\nPlease make sure that `left < right` and `top < bottom`. "
+        + "\nPlease make sure that `left &lt; right` and `top &lt; bottom`. "
         + "Also check for negative values in the 'methods' or 'fps_limit' settings"
     )