- Fix outposts not following the

min_distances_ignored_for_towns_in_same_nation and
min_distances_ignored_for_towns_in_allied_nation
    when min_distance_for_outpost_from_plot is tested while creating an
outpost using /t claim outpost.
    - Closes #7829.

Author: LlmDl

Towny/pom.xml

@@ -13,7 +13,7 @@
 
     <artifactId>towny</artifactId>
     <packaging>jar</packaging>
-    <version>0.102.0.7</version>
+    <version>0.102.0.8</version>
 
     <licenses>
         <license>

Towny/src/main/java/com/palmergames/bukkit/towny/command/PlotCommand.java

@@ -755,7 +755,7 @@ public void parsePlotSetOutpost(Player player, Resident resident, TownBlock town
 		Coord key = Coord.parseCoord(player.getLocation());
 
 		// Throws a TownyException with message if outpost should not be set.
-		OutpostUtil.OutpostTests(town, resident, townyWorld, key, resident.isAdmin(), true);
+		OutpostUtil.OutpostTests(town, resident, townyWorld, key, resident.isAdmin());
 
 		if (TownySettings.getOutpostCost() > 0) {
 			// Create a confirmation for setting outpost.

Towny/src/main/java/com/palmergames/bukkit/towny/command/TownCommand.java

@@ -3515,7 +3515,7 @@ private static List<WorldCoord> getTownClaimSelectionOrThrow(Player player, Stri
 
 			Resident resident = getResidentOrThrow(player);
 			// Run various tests required by configuration/permissions through Util.
-			OutpostUtil.OutpostTests(town, resident, world, playerWorldCoord, resident.isAdmin(), false);
+			OutpostUtil.OutpostTests(town, resident, world, playerWorldCoord, resident.isAdmin());
 
 			if (playerWorldCoord.hasTownBlock())
 				throw new TownyException(Translatable.of("msg_already_claimed", playerWorldCoord.getTownOrNull()));

Towny/src/main/java/com/palmergames/bukkit/towny/utils/OutpostUtil.java

@@ -17,23 +17,23 @@
 
 public class OutpostUtil {
 
-	/** 
-	 * Checks to make sure all requirements are met before an outpost can be claimed.
-	 * Will check:
-	 *   - If there are not enough free outpost plots
-	 *   - If the Outpost does not meet a minimum-distance requirement
+	/**
+	 * Checks to make sure all requirements are met before an outpost can be
+	 * claimed. Will check: <br>
+	 * 
+	 * - If there are not enough free outpost plots<br>
+	 * - If the Outpost does not meet a minimum-distance requirement
+	 * 
+	 * @param town     Town the outpost belongs to
+	 * @param resident Resident establishing the outpost
+	 * @param world    TownyWorld in which the outpost will be in
+	 * @param key      Coordinates where the outpost would be established
+	 * @param isAdmin  If the Resident is a Towny Administrator
 	 * 
-	 * @param town - Town the outpost belongs to
-	 * @param resident - Resident establishing the outpost
-	 * @param world - TownyWorld in which the outpost will be in
-	 * @param key - Coordinates where the outpost would be established
-	 * @param isAdmin - If the Resident is a Towny Administrator
-	 * @param isPlotSetOutpost - If a plot is already an outpost
-	 *    
 	 * @return - Returns true if all required tests for outposts are met.
 	 * @throws TownyException if a condition is not met.
 	 */
-	public static boolean OutpostTests(Town town, Resident resident, TownyWorld world, Coord key, boolean isAdmin, boolean isPlotSetOutpost) throws TownyException {
+	public static boolean OutpostTests(Town town, Resident resident, TownyWorld world, Coord key, boolean isAdmin) throws TownyException {
 
 		// The config can be set up to dole out numbers of outposts to towns based on resident counts/belonging to a nation.
 		if (TownySettings.isOutpostsLimitedByLevels() && (town.getMaxOutpostSpawn() >= town.getOutpostLimit()))
@@ -67,7 +67,7 @@ public static boolean OutpostTests(Town town, Resident resident, TownyWorld worl
 				throw new TownyException(Translatable.of("msg_err_not_close_enough_to_your_town_nearest_plot", distance, maxDistance));
 		}
 		// Outposts can have a minimum required distance from other towns' townblocks.
-		int minDistance = world.getMinDistanceFromOtherTownsPlots(key, isPlotSetOutpost ? town : null);
+		int minDistance = world.getMinDistanceFromOtherTownsPlots(key, town);
 		// Outposts can have a minimum required distance from other outposts.
 		if (minDistance < TownySettings.getMinDistanceFromTownPlotblocks() ||
 			minDistance < TownySettings.getMinDistanceForOutpostsFromPlot())

Towny/src/main/resources/ChangeLog.txt

@@ -10698,4 +10698,8 @@ v0.92.0.11:
     - Closes #8100.
   - Add PLOT_GROUP_TOGGLE to TownyCommandAddonAPI, courtesy of Veyronity with PR #8107.
   - Bump me.clip:placeholderapi from 2.11.7 to 2.12.2.
-  - Bump org.apache.maven.plugins:maven-compiler-plugin from 3.14.1 to 3.15.0.
+  - Bump org.apache.maven.plugins:maven-compiler-plugin from 3.14.1 to 3.15.0.
+0.102.0.8:
+  - Fix outposts not following the min_distances_ignored_for_towns_in_same_nation and min_distances_ignored_for_towns_in_allied_nation 
+    when min_distance_for_outpost_from_plot is tested while creating an outpost using /t claim outpost.
+    - Closes #7829.