(GH-47) wsus-config-update-products: Fixes Duplicate Product Name Selection (#48)

* Added For Loop to select all products that match - Removed unique from compare

* Fixed detection script - wsus-config-update-products

* Formatting fix

* Testing Update from other member

Co-authored-by: Andrew Ribeiro <[email protected]>
Co-authored-by: Michael Fyffe <[email protected]>

Author: 3 people

manifests/approvalrule.pp

@@ -76,7 +76,7 @@
             onlyif    => "\$ErrorActionPreference = \"Stop\"
                           \$wsus = Get-WsusServer
                           \$approvalRule = \$wsus.GetInstallApprovalRules() | Where-Object { \$PSItem.Name -eq \"${rule_name}\" }
-                          \$currentApprovalCategories = \$approvalRule.GetCategories() | Select-Object -ExpandProperty Title
+                          \$currentApprovalCategories = \$approvalRule.GetCategories() | Select-Object -ExpandProperty Title -Unique
                           if(\$currentApprovalCategories -eq \$null)
                           {
                             \$currentApprovalCategories = \"\"

manifests/config.pp

@@ -387,7 +387,7 @@
                           }
                           else {
                             # product title is valid. add it to the new collection
-                            [void]\$NewProducts.add( (\$allPossibleProducts | Where-Object {\$_.Title -eq \$product -and \$_.type -eq \$Type} | Select-Object -First 1) )
+                            [void]\$NewProducts.addRange( (\$allPossibleProducts | Where-Object {\$_.Title -eq \$product -and \$_.type -eq \$Type}) )
                           }
                         }
                       }
@@ -510,10 +510,10 @@
                       \$desired_productfamilies = \$commaSeparatedProductFamilies.Split(\";\")
                     }
                     # get current enabled product families, blank array if none
-                    \$currentEnabledProductFamilies = (\$wsusServerSubscription.GetUpdateCategories() | Where-Object {\$_.type -eq \"productfamily\"}).Title
+                    \$currentEnabledProductFamilies = (\$wsusServerSubscription.GetUpdateCategories() | Where-Object {\$_.type -eq \"productfamily\"}).Title | Select-Object -Unique
                     if (\$null -eq \$currentEnabledProductFamilies) { \$currentEnabledProductFamilies = @('') }
                     # get current enabled products, blank array if none
-                    \$currentEnabledProducts = (\$wsusServerSubscription.GetUpdateCategories() | Where-Object {\$_.type -eq \"product\"}).Title
+                    \$currentEnabledProducts = (\$wsusServerSubscription.GetUpdateCategories() | Where-Object {\$_.type -eq \"product\"}).Title | Select-Object -Unique
                     if (\$null -eq \$currentEnabledProducts) { \$currentEnabledProducts = @('') }
                     # compare product families
                     \$compareProductFamiliesResult = Compare-Object -ReferenceObject \$currentEnabledProductFamilies -DifferenceObject \$desired_productfamilies