Handle slashes in instance name of WaitExecutionRequest (#1689)

Co-authored-by: Jacob Pratt <[email protected]>

Author: barrbrain

nativelink-service/BUILD.bazel

@@ -3,6 +3,7 @@ load(
     "rust_doc",
     "rust_doc_test",
     "rust_library",
+    "rust_test",
     "rust_test_suite",
 )
 
@@ -85,6 +86,25 @@ rust_test_suite(
     ],
 )
 
+rust_test(
+    name = "unit_test",
+    timeout = "short",
+    crate = ":nativelink-service",
+    proc_macro_deps = [
+        "//nativelink-macro",
+        "@crates//:async-trait",
+    ],
+    deps = [
+        "//nativelink-metric",
+        "@crates//:async-lock",
+        "@crates//:hyper",
+        "@crates//:hyper-util",
+        "@crates//:maplit",
+        "@crates//:pretty_assertions",
+        "@crates//:prost-types",
+    ],
+)
+
 rust_doc(
     name = "docs",
     crate = ":nativelink-service",

nativelink-service/src/execution_server.rs

@@ -62,7 +62,7 @@ impl NativelinkOperationId {
 
     fn from_name(name: &str) -> Result<Self, Error> {
         let (instance_name, name) = name
-            .split_once('/')
+            .rsplit_once('/')
             .err_tip(|| "Expected instance_name and name to be separated by '/'")?;
         Ok(NativelinkOperationId::new(
             instance_name.to_string(),
@@ -383,3 +383,16 @@ impl Execution for ExecutionServer {
         resp
     }
 }
+
+#[cfg(test)]
+#[test]
+fn test_nl_op_id_from_name() -> Result<(), Box<dyn std::error::Error>> {
+    let examples = [("foo/bar", "foo"), ("a/b/c/d", "a/b/c")];
+
+    for (input, expected) in examples {
+        let id = NativelinkOperationId::from_name(input)?;
+        assert_eq!(id.instance_name, expected);
+    }
+
+    Ok(())
+}