Skip to content

Commit e99e74d

Browse files
committed
chore: Update pre-commit configuration and CLAUDE.md for enhanced pre-push checks
1 parent 1c17154 commit e99e74d

File tree

2 files changed

+35
-0
lines changed

2 files changed

+35
-0
lines changed

.pre-commit-config.yaml

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,3 +47,24 @@ repos:
4747
files: ^(tracecat|packages)
4848
require_serial: true
4949
pass_filenames: false
50+
- id: basedpyright
51+
name: python type check
52+
entry: uv run basedpyright --warnings --threads 4
53+
language: system
54+
types: [python]
55+
pass_filenames: false
56+
require_serial: true
57+
- id: biome-check
58+
name: frontend biome check
59+
entry: bash -c "pnpm -C frontend check"
60+
language: system
61+
files: ^frontend/
62+
pass_filenames: false
63+
require_serial: true
64+
- id: typecheck-frontend
65+
name: frontend type check
66+
entry: bash -c "pnpm -C frontend run typecheck"
67+
language: system
68+
files: ^frontend/
69+
pass_filenames: false
70+
require_serial: true

CLAUDE.md

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,12 +150,26 @@ uv run basedpyright tracecat/api/
150150
# - Using `Any` when a more specific type is possible
151151
```
152152

153+
### Pre-push Verification
154+
**IMPORTANT**: Always run these checks before pushing. Pre-commit hooks catch most issues, but you should verify locally if in doubt.
155+
```bash
156+
# Run all CI-equivalent checks (must all pass before pushing)
157+
uv run ruff check . # Python lint (strict, no auto-fix)
158+
uv run ruff format --check . # Python format check
159+
uv run basedpyright --warnings --threads 4 # Python type checking
160+
pnpm -C frontend check # Frontend lint + format (Biome)
161+
pnpm -C frontend run typecheck # TypeScript type checking
162+
```
163+
153164
**Pre-commit hooks**: Runs automatically on commit:
154165
- Ruff (lint + format)
155166
- Gitleaks (secret detection)
156167
- YAML/TOML validation
157168
- UV lock sync
158169
- Frontend client generation (when tracecat/packages change)
170+
- basedpyright (Python type checking)
171+
- Frontend Biome check (lint + format on frontend changes)
172+
- TypeScript type checking (on frontend changes)
159173

160174
**CI Requirements**: Both linting (`just fix`) and type checking (`just typecheck`) must pass in CI before merging.
161175

0 commit comments

Comments
 (0)