Enhances Docker deployment with secrets usage

Replaces environment variables with secrets for secure and consistent deployment
Strengthens best practices by centralizing configuration references

Author: mbertelsen

.github/workflows/docker-deploy.yml

@@ -51,22 +51,20 @@ jobs:
 
   deploy-to-appservice:
     needs: build-and-push
-    env:
-      EDITOR_APP_NAME: ${{ secrets.EDITOR_APP_NAME }}
-      RESOURCE_GROUP: ${{ secrets.RESOURCE_GROUP }}
-      EDITOR_API_APP_NAME: ${{ secrets.EDITOR_API_APP_NAME }}
-    if: ${{ env.EDITOR_APP_NAME != '' && env.RESOURCE_GROUP != '' && env.EDITOR_API_APP_NAME != '' }}
     runs-on: ubuntu-latest
     steps:
       - name: Azure Login
+        if: ${{ secrets.EDITOR_APP_NAME != '' && secrets.RESOURCE_GROUP != '' && secrets.EDITOR_API_APP_NAME != '' }}
         uses: azure/login@v1
         with:
           creds: ${{ secrets.AZURE_CREDENTIALS }}
 
       - name: Deploy editor to App Service (container)
+        if: ${{ secrets.EDITOR_APP_NAME != '' && secrets.RESOURCE_GROUP != '' && secrets.EDITOR_API_APP_NAME != '' }}
         run: |
-          az webapp config container set --name ${{ env.EDITOR_APP_NAME }} --resource-group ${{ env.RESOURCE_GROUP }} --docker-custom-image-name ${{ needs.build-and-push.outputs.registry }}/app-scripting-editor:latest
+          az webapp config container set --name ${{ secrets.EDITOR_APP_NAME }} --resource-group ${{ secrets.RESOURCE_GROUP }} --docker-custom-image-name ${{ needs.build-and-push.outputs.registry }}/app-scripting-editor:latest
 
       - name: Deploy editor-api to App Service (container)
+        if: ${{ secrets.EDITOR_APP_NAME != '' && secrets.RESOURCE_GROUP != '' && secrets.EDITOR_API_APP_NAME != '' }}
         run: |
-          az webapp config container set --name ${{ env.EDITOR_API_APP_NAME }} --resource-group ${{ env.RESOURCE_GROUP }} --docker-custom-image-name ${{ needs.build-and-push.outputs.registry }}/app-scripting-editor-api:latest
+          az webapp config container set --name ${{ secrets.EDITOR_API_APP_NAME }} --resource-group ${{ secrets.RESOURCE_GROUP }} --docker-custom-image-name ${{ needs.build-and-push.outputs.registry }}/app-scripting-editor-api:latest