Removes debug logs, refines error handling

Eliminates excessive console output for a cleaner codebase
and transitions to minimal error messages.
Removes legacy debugging utilities to improve production
readiness and reduce noise.

Author: mbertelsen

editor/src/components/FacilityDropdown.tsx

@@ -2,7 +2,7 @@ import React, { useState, useRef, useEffect } from 'react';
 import { useQuery } from 'urql';
 import { GET_FACILITIES_WITH_ACCESS, TEST_QUERY } from '../graphql/queries';
 import { debugEnvironment } from '../lib/debug-env';
-import { logEnvironmentInfo, logAuthError } from '../utils/debugUtils';
+
 
 interface Facility {
   id: string;
@@ -42,13 +42,11 @@ export const FacilityDropdown: React.FC<FacilityDropdownProps> = ({
   }, []);
 
   // Log detailed debugging info
-  console.log('🧪 Test Query Result:', testResult);
-  console.log('🏢 Facilities Query Result:', { data, fetching, error });
+
 
   // Enhanced error logging
   if (error && import.meta.env.DEV) {
-    logEnvironmentInfo();
-    logAuthError(error, 'Facilities Query');
+    console.error('Facilities Query Error:', error);
   }
 
   // Close dropdown when clicking outside

editor/src/components/FacilitySelectorPortal.tsx

@@ -60,7 +60,7 @@ export const FacilitySelectorPortal: React.FC<FacilitySelectorPortalProps> = ({
       const facilityToRestore = facilities.find((facility: Facility) => facility.id === selectedFacilityId);
       if (facilityToRestore) {
         onFacilitySelect(facilityToRestore);
-        console.log('Restored facility object from facilities list:', facilityToRestore);
+
       }
     }
   }, [facilities, selectedFacilityId, selectedFacility, onFacilitySelect]);
@@ -95,25 +95,6 @@ export const FacilitySelectorPortal: React.FC<FacilitySelectorPortalProps> = ({
   // Get facilities for current tab
   const currentFacilities = groupedFacilities[activeTab];
 
-  // Log access information for debugging
-  if (data?.facilities?.items && facilities.length > 0) {
-    console.log('🔍 Facility Access Debug:');
-    facilities.slice(0, 3).forEach((facility: Facility) => {
-      console.log(`  ${facility.name}:`, {
-        kind: facility.kind,
-        developerAccess: facility.developerAccess,
-        apiDeveloperAccess: facility.apiDeveloperAccess,
-        hasAccess: hasDeveloperAccess(facility)
-      });
-    });
-    console.log(`📊 Grouped facilities:`, {
-      Total: facilitiesWithAccess.length,
-      All: groupedFacilities.All.length,
-      Indoor: groupedFacilities.Indoor.length,
-      Range: groupedFacilities.Range.length
-    });
-  }
-
   const handleFacilityClick = (facility: Facility) => {
     if (selectedFacility?.id === facility.id) {
       // Deselect if clicking the same facility

editor/src/components/StepDialog.tsx

@@ -18,7 +18,7 @@ export const StepDialog: React.FC<StepDialogProps> = ({ open, onClose, onAdd, pa
 
   // Whenever dialog is (re)opened or parent activity type changes, reset the fields.
   useEffect(() => {
-    console.log('🔍 StepDialog useEffect:', { open, parentActivityType, parentActivityId });
+
     if (open) {
       setId('');
       setHeader('');
@@ -77,9 +77,7 @@ export const StepDialog: React.FC<StepDialogProps> = ({ open, onClose, onAdd, pa
           <button
             disabled={!id || !header}
             onClick={() => {
-              console.log('🔍 StepDialog Add Step button clicked:', { parentActivityType, parentActivityId, id, header });
               if (!parentActivityType || !parentActivityId) {
-                console.log('🔍 Missing parent info, returning early');
                 return;
               }
               const step: Step = createStep({
@@ -88,7 +86,7 @@ export const StepDialog: React.FC<StepDialogProps> = ({ open, onClose, onAdd, pa
                 introHeader: header,
                 introDescription: description,
               });
-              console.log('🔍 Created step:', step);
+
               onAdd(step, parentActivityId);
               onClose();
             }}

editor/src/components/TopBar.tsx

@@ -26,7 +26,7 @@ export const TopBar: React.FC<TopBarProps> = ({
 
   const handleFacilitySelect = (facility: Facility | null) => {
     onFacilitySelect(facility);
-    console.log('Selected facility:', facility);
+
     // - Storing selection in localStorage
   };
 

editor/src/editorReducer.ts

@@ -52,12 +52,7 @@ export function editorReducer(state: EditorState, action: EditorAction): EditorS
         selectedRef: action.select ? { kind: 'activity', activityId: action.activity.id } : state.selectedRef
       };
     case 'ADD_STEP': {
-      console.log('🔍 ADD_STEP reducer:', { 
-        parentActivityId: action.parentActivityId, 
-        stepId: action.step.id, 
-        select: action.select,
-        currentActivities: state.script.activities.map(a => ({ id: a.id, stepCount: a.steps.length }))
-      });
+
 
       const activities = state.script.activities.map(a =>
         a.id === action.parentActivityId ? { ...a, steps: [...a.steps, action.step] } : a
@@ -69,10 +64,7 @@ export function editorReducer(state: EditorState, action: EditorAction): EditorS
         selectedRef: action.select ? { kind: 'step' as const, activityId: action.parentActivityId, stepId: action.step.id } : state.selectedRef
       };
 
-      console.log('🔍 ADD_STEP result:', {
-        newActivities: newState.script.activities.map(a => ({ id: a.id, stepCount: a.steps.length, steps: a.steps.map(s => s.id) })),
-        newSelectedRef: newState.selectedRef
-      });
+
 
       return newState;
     }

editor/src/lib/AuthProvider.tsx

@@ -31,23 +31,19 @@ export const AuthProvider: React.FC<AuthProviderProps> = ({ children }) => {
   const checkAuthStatus = () => {
     // Only check for OAuth tokens (user authentication), not client credential tokens
     const isAuth = authService.isAuthenticated();
-    console.log('🔍 Checking auth status:', { isAuth, hasStoredToken: !!localStorage.getItem('trackman_auth_token') });
 
     setIsAuthenticated(isAuth);
     setIsLoading(false);
 
     if (!isAuth) {
-      console.log('❌ Not authenticated - user needs to log in');
       setError(null); // Don't show error for unauthenticated state
     } else {
-      console.log('✅ User is authenticated');
       setError(null);
     }
   };
 
   const login = async () => {
     // Client credential authentication has been removed - only OAuth login is supported
-    console.log('❌ Client credential login is no longer supported. Use OAuth login instead.');
     throw new Error('Client credential authentication is disabled. Please use OAuth login.');
   };
 
@@ -71,13 +67,11 @@ export const AuthProvider: React.FC<AuthProviderProps> = ({ children }) => {
     setIsLoading(true);
     try {
       await authService.logoutOAuth();
-      console.log('🔓 Logged out successfully, auth service will handle redirect...');
       // Don't reload here - let the auth service handle the redirect to logout completion page
     } catch (err) {
       // Fallback to local logout if server logout fails
       console.warn('⚠️ Server logout failed, falling back to local logout:', err);
       authService.clearToken();
-      console.log('🔓 Logged out locally, redirecting to login...');
       // Only reload if the auth service logout failed
       window.location.reload();
     }
@@ -91,7 +85,7 @@ export const AuthProvider: React.FC<AuthProviderProps> = ({ children }) => {
       authService.clearToken();
       await authService.getAccessToken();
       setIsAuthenticated(true);
-      console.log('🔄 Token refreshed successfully');
+
     } catch (err) {
       const errorMessage = err instanceof Error ? err.message : 'Token refresh failed';
       setError(errorMessage);

editor/src/lib/auth-service.ts

@@ -7,7 +7,7 @@ interface TokenResponse {
 }
 
 interface TokenData {
-  accessToken: string;
+ cessToken: string;
   tokenType: string;
   expiresAt: Date;
   refreshToken?: string;
@@ -35,15 +35,11 @@ class AuthService {
    * Get a valid access token (user tokens only - no client credentials)
    */
   public async getAccessToken(): Promise<string> {
-    console.log('🎫 getAccessToken() called');
-    
     // Only return user tokens, never client credential tokens
     if (this.tokenData && this.isTokenValid() && this.isAuthenticated()) {
-      console.log('✅ Using existing valid user token');
       return this.tokenData.accessToken;
     }
 
-    console.log('❌ No valid user token available - client must authenticate via OAuth');
     throw new Error('No valid user token available. User must log in via OAuth.');
   }
 
@@ -83,10 +79,6 @@ class AuthService {
    */
   private loadTokenFromStorage(): void {
     const stored = localStorage.getItem('trackman_auth_token');
-    console.log('🔍 Loading token from storage:', {
-      hasStoredToken: !!stored,
-      tokenPreview: stored ? stored.substring(0, 50) + '...' : 'none'
-    });
 
     if (stored) {
       try {
@@ -98,17 +90,8 @@ class AuthService {
           scope: parsed.scope,
         };
 
-        console.log('📦 Loaded token data:', {
-          hasAccessToken: !!this.tokenData.accessToken,
-          tokenType: this.tokenData.tokenType,
-          expiresAt: this.tokenData.expiresAt,
-          scope: this.tokenData.scope,
-          isValid: this.isTokenValid()
-        });
-
         // Clean up if token is expired
         if (!this.isTokenValid()) {
-          console.log('🗑️ Token is expired, clearing...');
           this.clearToken();
         }
       } catch (error) {
@@ -122,8 +105,6 @@ class AuthService {
    * Clear the current token and all authentication state
    */
   public clearToken(): void {
-    console.log('🧹 Clearing all authentication tokens and state...');
-    
     // Clear in-memory token
     this.tokenData = null;
 
@@ -136,17 +117,13 @@ class AuthService {
     sessionStorage.removeItem('oauth_code_verifier');
     sessionStorage.removeItem('oauth_state');
     sessionStorage.removeItem('oauth_processed');
-    
-    console.log('✅ All authentication state cleared');
   }
 
   /**
    * Force clear all authentication state and reload the page
    * Use this to completely reset authentication for testing
    */
   public forceResetAuthentication(): void {
-    console.log('🔴 Force resetting all authentication...');
-    
     // Clear all storage
     localStorage.clear();
     sessionStorage.clear();
@@ -155,7 +132,6 @@ class AuthService {
     this.tokenData = null;
     this.tokenRefreshPromise = null;
 
-    console.log('🔄 Reloading page to complete reset...');
     window.location.href = window.location.origin;
   }
 
@@ -172,40 +148,41 @@ class AuthService {
     try {
       localStorage.clear();
       sessionStorage.clear();
-      console.log('🧹 Cleared all browser storage');
+
     } catch (error) {
       console.warn('Failed to clear storage:', error);
     }
 
-    // Use TrackMan portal approach: redirect directly to server logout endpoint
-    // This lets the OAuth server handle session clearing and proper logout flow
+    // Mimic what the portal's /account/logout endpoint does:
+    // Redirect to OAuth logout with returnUrl parameter (exactly like portal)
     try {
       const { ENV_URLS, OAUTH_CONFIG } = await import('./env');
 
-      // Build logout URL with returnUrl parameter (exactly like portal approach)
+      // This is what we want to return to after logout
       const returnUrl = `${window.location.origin}/?logout_complete=true&t=${Date.now()}`;
+      
+      // Build the OAuth logout URL exactly like the portal's server would
       const logoutUrl = new URL(`${ENV_URLS.loginBase}/connect/endsession`);
 
-      // Add required parameters for proper logout
       if (OAUTH_CONFIG.webClientId) {
         logoutUrl.searchParams.set('client_id', OAUTH_CONFIG.webClientId);
       }
 
-      // Use both standard OAuth parameter and portal-style returnUrl
-      logoutUrl.searchParams.set('post_logout_redirect_uri', returnUrl);
-      logoutUrl.searchParams.set('returnUrl', encodeURIComponent(returnUrl)); // Portal style
+      // Use the same returnUrl parameter format as the portal
+      logoutUrl.searchParams.set('returnUrl', returnUrl);
 
-      console.log('🔄 Redirecting to TrackMan logout endpoint:', logoutUrl.toString());
+      console.log('🔄 Mimicking portal logout: redirecting to OAuth logout with returnUrl');
+      console.log('� OAuth logout URL:', logoutUrl.toString());
       console.log('🔍 Return URL after logout:', returnUrl);
 
-      // Direct redirect to OAuth server logout (like portal does)
+      // Redirect to OAuth logout (this is what portal's /account/logout does)
       window.location.href = logoutUrl.toString();
 
     } catch (error) {
-      console.error('❌ Failed to build logout URL:', error);
-      // Fallback to simple logout completion page
+      console.error('❌ Failed to build OAuth logout URL:', error);
+      // Fallback
       const fallbackUrl = `${window.location.origin}/?logout_complete=true&t=${Date.now()}`;
-      console.log('🔄 Fallback: Redirecting to logout completion page:', fallbackUrl);
+
       window.location.href = fallbackUrl;
     }
   }
@@ -223,12 +200,7 @@ class AuthService {
     const scope = this.tokenData.scope || '';
     const hasUserScopes = scope.includes('openid') || scope.includes('profile') || scope.includes('email');
 
-    console.log('🔍 Authentication check:', {
-      hasToken: !!this.tokenData,
-      isValid: this.isTokenValid(),
-      scope: scope,
-      hasUserScopes: hasUserScopes
-    });
+
 
     return hasUserScopes;
   }
@@ -247,19 +219,7 @@ class AuthService {
     const { buildAuthorizationUrl, generateCodeVerifier, generateState } = await import('./oauth2-utils');
     const { ENV_URLS, OAUTH_CONFIG } = await import('./env');
 
-    console.log('🚀 Starting OAuth login flow...');
-    console.log('🔍 startOAuthLogin called with prompt parameter:', prompt);
-    if (prompt) {
-      console.log('🔑 Using prompt parameter:', prompt, '- This will force login screen');
-    } else {
-      console.log('⚠️ No prompt parameter provided - may auto-login if server session exists');
-    }
-    console.log('OAuth Config:', {
-      webClientId: OAUTH_CONFIG.webClientId,
-      redirectUri: OAUTH_CONFIG.redirectUri,
-      loginBaseUrl: ENV_URLS.loginBase,
-      scopes: OAUTH_CONFIG.scopes
-    });
+
 
     // Check for required configuration
     if (!OAUTH_CONFIG.webClientId) {
@@ -279,10 +239,7 @@ class AuthService {
     const codeVerifier = generateCodeVerifier();
     const state = generateState();
 
-    console.log('📝 Generated PKCE parameters:', {
-      codeVerifierLength: codeVerifier.length,
-      stateLength: state.length
-    });
+
 
     // Store PKCE parameters in sessionStorage for callback
     sessionStorage.setItem('oauth_code_verifier', codeVerifier);
@@ -301,8 +258,7 @@ class AuthService {
       prompt
     );
 
-    console.log('🔗 Authorization URL:', authUrl);
-    console.log('🌐 About to redirect to TrackMan login server...');
+
 
     // Redirect to login server
     window.location.href = authUrl;
@@ -315,7 +271,7 @@ class AuthService {
     const { parseAuthorizationCallback, exchangeCodeForToken } = await import('./oauth2-utils');
     const { ENV_URLS, OAUTH_CONFIG } = await import('./env');
 
-    console.log('🔄 Processing OAuth callback...');
+
 
     // Parse callback URL
     const { code, state, error, error_description } = parseAuthorizationCallback(callbackUrl);
@@ -367,9 +323,7 @@ class AuthService {
       this.tokenData = tokenData;
       this.saveTokenToStorage();
 
-      console.log('✅ OAuth login successful!');
-      console.log('  Token expires at:', tokenData.expiresAt);
-      console.log('  Scopes:', tokenData.scope);
+
 
     } finally {
       // Clean up session storage