Prevents repeated re-init, hides debug in production

Ensures persisted data is restored only once to avoid re-initialization conflicts
Restricts environment logs to non-production mode, reducing noise and potential exposure in production

Author: mbertelsen

editor/src/App.tsx

@@ -1,4 +1,4 @@
-import React, { useState, useEffect, useReducer } from 'react';
+import React, { useState, useEffect, useReducer, useRef } from 'react';
 import './treeview.css';
 import { TopBar } from './components/TopBar';
 import { TabBar } from './components/TabBar';
@@ -55,6 +55,9 @@ export default function App() {
   const [selectedBayId, setSelectedBayId] = useState<string | null>(null);
   const [selectedBayObj, setSelectedBayObj] = useState<Bay | null>(null);
 
+  // Track if we've initialized from persistence to prevent re-initialization
+  const hasInitializedFromPersistence = useRef(false);
+  
   const { script } = state;
   const { isValid, errors: validationErrors } = state.validation;
 
@@ -278,10 +281,11 @@ export default function App() {
     dispatch({ type: 'SET_VALIDATION', isValid: valid, errors: formatErrors(errors) });
   }, [script]);
 
-  // Initialize selections from persisted data on startup
+  // Initialize selections from persisted data on startup (only once)
   useEffect(() => {
-    if (!isLoadingSelections && selections) {
-      if (selections.facilityId && selections.facilityId !== selectedFacilityId) {
+    if (!isLoadingSelections && selections && !hasInitializedFromPersistence.current) {
+      // Only restore facility if we don't already have one selected
+      if (selections.facilityId && !selectedFacilityId) {
         setSelectedFacilityId(selections.facilityId);
         console.log('Restored facility ID from persistence:', selections.facilityId);
         // Note: The facility object will be restored by the FacilitySelectorPortal 
@@ -294,6 +298,9 @@ export default function App() {
       if (selections.bayId) {
         console.log('Will restore bay ID from persistence:', selections.bayId);
       }
+      
+      // Mark as initialized to prevent re-running
+      hasInitializedFromPersistence.current = true;
     }
   }, [isLoadingSelections, selections, selectedFacilityId]);
 

editor/src/components/EnvironmentDebug.tsx

@@ -6,9 +6,13 @@ export const EnvironmentDebug: React.FC = () => {
   const loginBase = import.meta.env.VITE_LOGIN_BASE_URL;
   const nodeEnv = import.meta.env.VITE_NODE_ENV;
   const mode = import.meta.env.MODE;
+  
+  // Check runtime configuration for production mode
+  const runtimeNodeEnv = (window as any)?.runtimeConfig?.VITE_NODE_ENV;
+  const isProduction = runtimeNodeEnv === 'production';
 
-  // Only show in development or when there are issues
-  if (!isDevelopment && backendBase && loginBase) {
+  // Only show in development or when there are issues, hide in production
+  if (isProduction || (!isDevelopment && backendBase && loginBase)) {
     return null;
   }
 

editor/src/lib/env.ts

@@ -79,17 +79,20 @@ export const ENV_URLS = {
   oauthToken: loginBase ? `${loginBase}/connect/token` : import.meta.env.VITE_OAUTH_TOKEN_URL || '',
 };
 
-// Debug environment loading
-console.log('🔍 Environment Debug:', {
-  backendBase,
-  loginBase,
-  'runtimeConfig.VITE_NODE_ENV': (window as any)?.runtimeConfig?.VITE_NODE_ENV || 'NOT SET',
-  'import.meta.env.VITE_NODE_ENV': import.meta.env.VITE_NODE_ENV || 'NOT SET',
-  'import.meta.env.VITE_BACKEND_BASE_URL': import.meta.env.VITE_BACKEND_BASE_URL,
-  'import.meta.env.VITE_LOGIN_BASE_URL': import.meta.env.VITE_LOGIN_BASE_URL,
-  'import.meta.env.VITE_OAUTH_WEB_CLIENT_ID': import.meta.env.VITE_OAUTH_WEB_CLIENT_ID ? 'SET' : 'NOT SET',
-  ENV_URLS
-});
+// Debug environment loading (only in development)
+const isProduction = (window as any)?.runtimeConfig?.VITE_NODE_ENV === 'production';
+if (!isProduction) {
+  console.log('🔍 Environment Debug:', {
+    backendBase,
+    loginBase,
+    'runtimeConfig.VITE_NODE_ENV': (window as any)?.runtimeConfig?.VITE_NODE_ENV || 'NOT SET',
+    'import.meta.env.VITE_NODE_ENV': import.meta.env.VITE_NODE_ENV || 'NOT SET',
+    'import.meta.env.VITE_BACKEND_BASE_URL': import.meta.env.VITE_BACKEND_BASE_URL,
+    'import.meta.env.VITE_LOGIN_BASE_URL': import.meta.env.VITE_LOGIN_BASE_URL,
+    'import.meta.env.VITE_OAUTH_WEB_CLIENT_ID': import.meta.env.VITE_OAUTH_WEB_CLIENT_ID ? 'SET' : 'NOT SET',
+    ENV_URLS
+  });
+}
 
 // OAuth Web Client Configuration (for authorization code flow)
 // Function to get OAuth client ID - with runtime support
@@ -160,7 +163,10 @@ export const OAUTH_CONFIG = {
 };
 
 export function assertRequiredUrls() {
-  console.log('🔍 Asserting required URLs:', ENV_URLS);
+  const isProduction = (window as any)?.runtimeConfig?.VITE_NODE_ENV === 'production';
+  if (!isProduction) {
+    console.log('🔍 Asserting required URLs:', ENV_URLS);
+  }
 
   if (!ENV_URLS.graphql) {
     console.error('❌ GraphQL endpoint is not configured:', {