Skip to content

Commit 007d260

Browse files
committed
Fixed handling of disabled-tests options
* tests to be disabled are listed by name in an external file, one per line. these are read from disk line-by-line into an array, and later put back together into a single string with a newline ("\n") separator, presumably for marshalling over IPC. before this fix, there was an attempt to split these out again using an overload of `StringArray::fromTokens` which uses whitespace delimiters, ultimately causing test cases with spaces in to not be disabled (e.g. "Automatable Parameters" end up in the options array as two entries, so the test case isn't picked up as a match). using `StringArray::fromLines` fixes the issue
1 parent 3362803 commit 007d260

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Source/Validator.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -474,7 +474,7 @@ class ValidatorSlaveProcess : public ChildProcessSlave,
474474
options.dataFile = File (v[IDs::dataFile].toString());
475475
options.outputDir = File (v[IDs::outputDir].toString());
476476
options.withGUI = v.getProperty (IDs::withGUI, true);
477-
options.disabledTests = StringArray::fromTokens (v.getProperty (IDs::disabledTests).toString(), false);
477+
options.disabledTests = StringArray::fromLines (v.getProperty (IDs::disabledTests).toString());
478478

479479
for (auto c : v)
480480
{

0 commit comments

Comments
 (0)