Skip to content

Commit 5791a16

Browse files
authored
Made parameter state restoration test specific for each parameter (#101)
1 parent 0f80a9d commit 5791a16

File tree

1 file changed

+11
-9
lines changed

1 file changed

+11
-9
lines changed

Source/tests/BasicTests.cpp

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -313,19 +313,21 @@ struct PluginStateTestRestoration : public PluginTest
313313
// Read state
314314
auto originalState = callGetStateInformationOnMessageThreadIfVST3 (instance);
315315

316-
// Check current sum of parameter values
317-
const float originalParamsSum = getParametersSum (instance);
316+
const auto tolaratedDiff = 0.1f;
318317

319318
// Set random parameter values
320-
for (auto parameter : getNonBypassAutomatableParameters (instance))
321-
parameter->setValue (r.nextFloat());
319+
for (auto parameter : getNonBypassAutomatableParameters(instance))
320+
{
321+
const auto expectedValue = r.nextFloat();
322+
parameter->setValue(expectedValue);
322323

323-
// Restore original state
324-
callSetStateInformationOnMessageThreadIfVST3 (instance, originalState);
324+
// Restore original state
325+
callSetStateInformationOnMessageThreadIfVST3(instance, originalState);
325326

326-
// Check parameter values return to original
327-
ut.expectWithinAbsoluteError (getParametersSum (instance), originalParamsSum, 0.1f,
328-
"Parameters not restored on setStateInformation");
327+
// Check parameter values return to original
328+
ut.expectWithinAbsoluteError(parameter->getValue(), expectedValue, tolaratedDiff,
329+
parameter->getName(1024) << " not restored on setStateInformation");
330+
}
329331

330332
if (strictnessLevel >= 8)
331333
{

0 commit comments

Comments
 (0)